Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Do not call self.close() if there are no open dialogs. #436

Closed
wants to merge 1 commit into from
Closed

Do not call self.close() if there are no open dialogs. #436

wants to merge 1 commit into from

Conversation

beppler
Copy link

@beppler beppler commented May 14, 2013

Do this to not break the activeBackdrops semaphore and after this, the backdrop will not be shown again.

@beppler
Do not call self.close() if there are no open dialogs.
0d49f6f 
Do this to not break the activeBackdrops semaphore.
@beppler
Copy link
Author

beppler commented May 15, 2013

This PR relates to #379.

@yanl yanl mentioned this pull request May 21, 2013
Closed
@pkozlowski-opensource
Copy link
Member

@beppler thnx for this PR but the current $dialog code is kind of broken from the design point of view and I'm in process of rewriting it right now in scope of #441

Prefer to focus on rewrites instead of patching broken code. Thnx for your work and heads up though!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beppler @pkozlowski-opensource