Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(carousel): hide prev/next if not loop and indexes at bounds #5708

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/carousel/carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,14 @@ angular.module('ui.bootstrap.carousel', [])
return $scope.active === slide.slide.index;
};

$scope.isPrevDisabled = function() {
return $scope.active === 0 && $scope.noWrap();
};

$scope.isNextDisabled = function() {
return $scope.active === slides.length - 1 && $scope.noWrap();
};

$scope.pause = function() {
if (!$scope.noPause) {
isPlaying = false;
Expand Down
32 changes: 32 additions & 0 deletions src/carousel/test/carousel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,38 @@ describe('carousel', function() {
expect(navPrev.length).toBe(0);
});

it('should disable prev button when slide index is 0 and noWrap is truthy', function() {
scope.$apply();

var $scope = elm.isolateScope();
$scope.noWrap = function() {return true;};

$scope.isPrevDisabled();
scope.$apply();

var navPrev = elm.find('a.left');
expect(navPrev.hasClass('disabled')).toBe(true);
});

it('should disable next button when last slide is active and noWrap is truthy', function() {
scope.slides = [
{content: 'one', index: 0},
{content: 'two', index: 1}
];

scope.$apply();

var $scope = elm.isolateScope();
$scope.noWrap = function() {return true;};
$scope.next();

$scope.isNextDisabled();
scope.$apply();

var navNext = elm.find('a.right');
expect(navNext.hasClass('disabled')).toBe(true);
});

it('should show navigation when there are 3 slides', function () {
var indicators = elm.find('ol.carousel-indicators > li');
expect(indicators.length).not.toBe(0);
Expand Down
4 changes: 2 additions & 2 deletions template/carousel/carousel.html
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<div ng-mouseenter="pause()" ng-mouseleave="play()" class="carousel" ng-swipe-right="prev()" ng-swipe-left="next()">
<div class="carousel-inner" ng-transclude></div>
<a role="button" href class="left carousel-control" ng-click="prev()" ng-show="slides.length > 1">
<a role="button" href class="left carousel-control" ng-click="prev()" ng-class="{ disabled: isPrevDisabled() }" ng-show="slides.length > 1">
<span aria-hidden="true" class="glyphicon glyphicon-chevron-left"></span>
<span class="sr-only">previous</span>
</a>
<a role="button" href class="right carousel-control" ng-click="next()" ng-show="slides.length > 1">
<a role="button" href class="right carousel-control" ng-click="next()" ng-class="{ disabled: isNextDisabled() }" ng-show="slides.length > 1">
<span aria-hidden="true" class="glyphicon glyphicon-chevron-right"></span>
<span class="sr-only">next</span>
</a>
Expand Down