New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filterFunc is not working properly with 0 value #522

Closed

aleshchenko opened this issue Jul 1, 2013 · 1 comment

aleshchenko commented Jul 1, 2013

self.evalFilter -> filterFunc is not working properly when value is numeric 0.
Problem is here (line 2154, build 2.0.6):

if (!value || !result) {
    return false;
}

!0 returns true.
Should be fixed like this:

if (value === undefined || value === null || !result) {
    return false;
}

jonricaurte added a commit that referenced this issue


          Fix for #522

a8508db

Contributor

jonricaurte commented Jul 1, 2013

Thanks. Should be fixed in latest 2.0.7.

jonricaurte closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment