Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support npm linked libraries #1875

Closed
ert78gb opened this issue Aug 29, 2016 · 4 comments · Fixed by #2291
Closed

Support npm linked libraries #1875

ert78gb opened this issue Aug 29, 2016 · 4 comments · Fixed by #2291
Labels
needs: investigation Requires some digging to determine if action is needed

Comments

@ert78gb
Copy link

ert78gb commented Aug 29, 2016

Please provide us with the following information:

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    El Capitan 10.11.6
  2. Versions. Please run ng --version. If there's nothing outputted, please run
    in a Terminal: node --version and paste the result here:
    Could not start watchman; falling back to NodeWatcher for file system events.
    Visit http://ember-cli.com/user-guide/#watchman for more info.
    angular-cli: 1.0.0-beta.11-webpack.2
    node: 6.3.1
    os: darwin x64
  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
  • checkout git repository
  • cd into directory
  • npm link
  • go to main project
  • npm install 'linked package'
  • ng build

If I commit the changes and npm install directly from github repo. everything is working

  1. The log given by the failure. Normally this include a stack trace and some
    more information.
    null pointer exception when loading RC5 module.
  2. Mention any other details that might be useful.
    https://webpack.github.io/docs/troubleshooting.html
  3. npm linked modules don’t find their dependencies

Thanks! We'll be in touch soon.

@ghidoz
Copy link

ghidoz commented Sep 4, 2016

Same for me. The solution should be add these lines to the webpack config:

module.exports = {
  resolve: { fallback: path.join(__dirname, "node_modules") },
  resolveLoader: { fallback: path.join(__dirname, "node_modules") }
};

But there is no webpack config that we can edit!

@filipesilva filipesilva added the needs: investigation Requires some digging to determine if action is needed label Sep 20, 2016
@filipesilva
Copy link
Contributor

Would you be willing to submit a PR to add those options?

@TheLarkInn can you have a look at this solution? It's the one listed in http://webpack.github.io/docs/troubleshooting.html#npm-linked-modules-doesn-t-find-their-dependencies

@serhiisol
Copy link
Contributor

serhiisol commented Sep 22, 2016

I've found solution for that and I'll make a pull request ;) hold on guys :)

(#2291)

@filipesilva, @TheLarkInn Could you guys take a look at my PR ? Thanks

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants