-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma builder logs a lot of file changes with "builderMode: application" #28755
Labels
area: @angular-devkit/build-angular
devkit/build-angular:karma
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Comments
alan-agius4
added
type: bug/fix
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
devkit/build-angular:karma
area: @angular/build
area: @angular-devkit/build-angular
and removed
area: @angular/build
labels
Oct 31, 2024
jkrems
added a commit
to jkrems/angular-cli
that referenced
this issue
Nov 5, 2024
The Karma file watching was racing with the file writes done by the application builder. Since we already tell Karma when to reun via `.refeshFiles()`, disabling Karma's own file watcher should make things more reliable. This allows removing a weird special-case in the test case and removes the noisy "File chaned" logs generated by Karma. Fixes angular#28755
jkrems
added a commit
to jkrems/angular-cli
that referenced
this issue
Nov 5, 2024
The Karma file watching was racing with the file writes done by the application builder. Since we already tell Karma when to reun via `.refeshFiles()`, disabling Karma's own file watcher should make things more reliable. This allows removing a weird special-case in the test case and removes the noisy "File chaned" logs generated by Karma. Fixes angular#28755
jkrems
added a commit
to jkrems/angular-cli
that referenced
this issue
Nov 5, 2024
The Karma file watching was racing with the file writes done by the application builder. Since we already tell Karma when to reun via `.refeshFiles()`, disabling Karma's own file watcher should make things more reliable. This allows removing a weird special-case in the test case and removes the noisy "File chaned" logs generated by Karma. Fixes angular#28755
jkrems
added a commit
to jkrems/angular-cli
that referenced
this issue
Nov 5, 2024
The Karma file watching was racing with the file writes done by the application builder. Since we already tell Karma when to reun via `.refeshFiles()`, disabling Karma's own file watcher should make things more reliable. This allows removing a weird special-case in the test case and removes the noisy "File chaned" logs generated by Karma. Fixes angular#28755
jkrems
added a commit
that referenced
this issue
Nov 5, 2024
The Karma file watching was racing with the file writes done by the application builder. Since we already tell Karma when to reun via `.refeshFiles()`, disabling Karma's own file watcher should make things more reliable. This allows removing a weird special-case in the test case and removes the noisy "File chaned" logs generated by Karma. Fixes #28755
jkrems
added a commit
that referenced
this issue
Nov 5, 2024
The Karma file watching was racing with the file writes done by the application builder. Since we already tell Karma when to reun via `.refeshFiles()`, disabling Karma's own file watcher should make things more reliable. This allows removing a weird special-case in the test case and removes the noisy "File chaned" logs generated by Karma. Fixes #28755 (cherry picked from commit faabbbf)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: @angular-devkit/build-angular
devkit/build-angular:karma
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Command
test
Is this a regression?
The previous version in which this bug was not present was
No response
Description
When running
ng test
in watch mode, updating a file triggers a re-run of the tests as expected, but sometimes logs a lot of file changes.Minimal Reproduction
Create a new project with
npx @angular/[email protected] new karma-assets --defaults --no-routing
.Add
"builderMode": "application",
to angular.json in the karmaoptions.Launch
ng test
Clear the template
app.component.html
and check the logs.Exception or Error
31 10 2024 07:31:27.111:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/app.component.spec.js.map".
31 10 2024 07:31:27.112:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/styles.css.map".
31 10 2024 07:31:27.112:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/styles.css".
31 10 2024 07:31:27.113:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/init_test_bed.js".
31 10 2024 07:31:27.113:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/app.component.spec.js".
31 10 2024 07:31:27.113:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/app.component.css.map".
31 10 2024 07:31:27.114:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/polyfills.js".
31 10 2024 07:31:27.116:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/init_test_bed.js.map".
31 10 2024 07:31:27.122:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/chunk-K7Q6MHAJ.js".
31 10 2024 07:31:27.128:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/polyfills.js.map".
31 10 2024 07:31:27.155:INFO [filelist]: Changed file "/Users/cedric/Code/temp/karma-assets/dist/test-out/c45dfc31-7cf6-461e-b12e-14642f1f29ac/chunk-K7Q6MHAJ.js.map".
Your Environment
Angular CLI: 19.0.0-rc.0
Node: 20.13.1
Package Manager: npm 9.7.1
OS: darwin arm64
Angular: 19.0.0-rc.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Package Version
@angular-devkit/architect 0.1900.0-rc.0
@angular-devkit/build-angular 19.0.0-rc.0
@angular-devkit/core 19.0.0-rc.0
@angular-devkit/schematics 19.0.0-rc.0
@schematics/angular 19.0.0-rc.0
rxjs 7.8.1
typescript 5.6.3
zone.js 0.15.0
Anything else relevant?
No response
The text was updated successfully, but these errors were encountered: