Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Polyfills #4140

Closed
hansl opened this issue Jan 20, 2017 · 1 comment · Fixed by #3812
Closed

Tracking: Polyfills #4140

hansl opened this issue Jan 20, 2017 · 1 comment · Fixed by #3812
Assignees
@filipesilva

Comments

@hansl
Copy link
Contributor

hansl commented Jan 20, 2017

Where do we put them?
@filipesilva filipesilva mentioned this issue Jan 20, 2017
Merged
@filipesilva filipesilva self-assigned this Jan 20, 2017
filipesilva added a commit that referenced this issue Jan 20, 2017
@filipesilva
fix(polyfills): move polyfills to own entry point (#3812)
08bb738 
Polyfills found in polyfills.ts would not be available for scripts due to being loaded in the main bundle only.

This PR loads polyfills as a separate entry point, before everything else.

Extra documentation also added to polyfills.ts.

Fix #2752
Fix #3309
Fix #4140
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@filipesilva @MRHarrison
fix(polyfills): move polyfills to own entry point (angular#3812)
e0f5681 
Polyfills found in polyfills.ts would not be available for scripts due to being loaded in the main bundle only.

This PR loads polyfills as a separate entry point, before everything else.

Extra documentation also added to polyfills.ts.

Fix angular#2752
Fix angular#3309
Fix angular#4140
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filipesilva filipesilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(polyfills): move polyfills to own entry point filipesilva/angular-cli
2 participants
@hansl @filipesilva