bug(commonjs): erroneous ngfactory #7910

CaerusKaru · 2017-10-03T02:26:04Z

Bug Report or Feature Request (mark with an `x`)

- [x] bug report
- [ ] feature request

Versions.

@angular/cli: 1.5.0-beta.2
node: 8.6.0
os: darwin x64
@angular/animations: 5.0.0-rc.0
@angular/cdk: 2.0.0-beta.11
@angular/common: 5.0.0-rc.0
@angular/compiler: 5.0.0-rc.0
@angular/core: 5.0.0-rc.0
@angular/forms: 5.0.0-rc.0
@angular/http: 5.0.0-rc.0
@angular/material: 2.0.0-beta.11
@angular/platform-browser: 5.0.0-rc.0
@angular/platform-browser-dynamic: 5.0.0-rc.0
@angular/platform-server: 5.0.0-rc.0
@angular/router: 5.0.0-rc.0
@angular/cli: 1.5.0-beta.2
@angular/compiler-cli: 5.0.0-rc.0
@angular/language-service: 5.0.0-rc.0
typescript: 2.5.3

Repro steps.

Clone the sample repo found here
Change into the cli directory
Run npm install and npm run build:dynamic

To show the second type of error (detailed below):

After the steps above, remove MatCardModule from app.module.ts, and remove the reference to <mat-card> in app.component.ts.
Run npm run build:dynamic && npm run serve:dynamic (which should succeed this time)
Navigate to localhost:4000. Disable JavaScript and reload the page
Attempt to navigate to the lazy route, examine the server for the error log

To show the third type of error (detailed below):

Re-enable JavaScript on localhost:4000 and reload the page
Attempt to navigate to the lazy route, examine the browser console for the error log

The log given by the failure.

ERROR in ./dist/server/main.bundle.js
Module not found: Error: Can't resolve '@angular/material/card/typings/index.ngfactory' in '/Users/main/universal-cli-bug/cli/dist/server'
 @ ./dist/server/main.bundle.js 1:2433-2490
 @ ./prerender.ts

Desired functionality.

AOT compilation needs to work for commonjs bundling where the bundle includes a lazy-loaded module that also includes an external module like Angular Material.

Mention any other details that might be useful.

This is an issue only when the external module is included in a lazy-loaded module. If it's included at the top-level, it works as expected. It also works as expected in [email protected]

The text was updated successfully, but these errors were encountered:

CaerusKaru · 2017-10-24T11:50:59Z

@filipesilva Is there any update on this issue? I feel like 1.5.0 is nearing final and there has been no progress made here.

To add on to symptoms of this issue, adding the bundle-dependencies flag results in a different error:

Error: No NgModule metadata found for '[object Object]'. This error occurs when the server spins up and tries to compile the module with JIT

When running without the flag, the bundle size for the main module is also significantly smaller than it should be (which makes sense, since most of the lazy-loaded content isn't being compiled).

cc @hansl for bundle-dependencies issue

filipesilva · 2017-10-24T12:16:28Z

@CaerusKaru do you think this is related to #7901 perhaps? It also had to do with lazy modules and #8157 fixed it.

@Brocco can you have a look?

CaerusKaru · 2017-10-24T12:50:22Z

@filipesilva It's unrelated, the issue persists in RC.3

@Brocco Here's the updated rub, as far as my investigations have gone:

The error no longer surfaces during bundling when the module in question is lazy-loaded, but it does surface now when the module is imported at the top level (I've updated the repo above to reflect this)
If the top-level import is removed, the build succeeds, but navigating to the lazy-loaded page with the module returns the following error:

TypeError: factory.create is not a function
    at MapSubscriber.project (/Users/main/universal-cli-bug/cli/dist/server.js:132272:51)
    at MapSubscriber._next (/Users/main/universal-cli-bug/cli/dist/server.js:135287:35)
    at MapSubscriber.Subscriber.next (/Users/main/universal-cli-bug/cli/dist/server.js:26375:18)
    at /Users/main/universal-cli-bug/cli/dist/server.js:109872:36
    at ZoneDelegate.invoke (/Users/main/universal-cli-bug/cli/dist/server.js:123046:26)
    at Object.onInvoke (/Users/main/universal-cli-bug/cli/dist/server.js:5080:33)
    at ZoneDelegate.invoke (/Users/main/universal-cli-bug/cli/dist/server.js:123045:32)
    at Zone.run (/Users/main/universal-cli-bug/cli/dist/server.js:122796:43)
    at /Users/main/universal-cli-bug/cli/dist/server.js:123527:57
    at ZoneDelegate.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123079:31)
    at resolvePromise (/Users/main/universal-cli-bug/cli/dist/server.js:123478:31)
    at resolvePromise (/Users/main/universal-cli-bug/cli/dist/server.js:123449:17)
    at /Users/main/universal-cli-bug/cli/dist/server.js:123527:17
    at ZoneDelegate.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123079:31)
    at Object.onInvokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:5071:33)
    at ZoneDelegate.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123078:36)
    at Zone.runTask (/Users/main/universal-cli-bug/cli/dist/server.js:122846:47)
    at drainMicroTaskQueue (/Users/main/universal-cli-bug/cli/dist/server.js:123256:35)
    at ZoneTask.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123157:21)
    at Server.ZoneTask.invoke (/Users/main/universal-cli-bug/cli/dist/server.js:123142:48)

I'm hoping this is a simple module resolution issue, because it's incredibly frustrating.

filipesilva · 2017-10-24T13:21:51Z

@MarkPieszak @Toxicable do you have any insight maybe?

hansl · 2017-10-25T19:33:03Z

Some sub issues should be fixed with #8188

MarkPieszak · 2017-10-26T00:19:50Z

I haven't seen this one yet, but i'll take a look!

CaerusKaru · 2017-10-26T01:37:27Z

@hansl I installed cli-builds with #8188, but now the build doesn't respect tsconfig paths specified as follows:

"paths": {
  "@app/*": ["app/*"],
  "@env/*": ["environments/*"]
}

Additionally, the server build is still not built correctly (without the paths)

CaerusKaru · 2017-10-26T03:36:14Z

ng serve --aot issues fixed by #8188, deleted above comment.

CaerusKaru · 2017-10-26T03:43:25Z

#8188 also fixes the ng build --prod issues for the browser build, but the server build is still busted.

vikerman · 2017-10-26T06:55:23Z

Can reproduce the server issue with Angular rc.6 and CLI 1.5 RC.3 and universal-starter repo.

LAZY_MODULE_MAP generated inside the server bundle has reference to the Module instead of the NgModuleFactory - causing factory.create to be undefined.

hansl · 2017-10-26T17:28:43Z

We have a separate fix for lazy modules in ng5. The problem is that making it work for ng5 seems to break ng4 so we'll do another RC with this fix whren it's ready (today hopefully)

CaerusKaru · 2017-10-27T02:32:17Z

In case 7a36f6a was designed to be the fix, it does not fix the issue.

Toxicable · 2017-10-27T04:09:49Z

@CaerusKaru what error are you getting?
the universal-starter upgraded to the latest versions is working fine for me

CaerusKaru · 2017-10-27T04:11:32Z

@Toxicable To be clear, this is when you import an Angular Material module into any NgModule (lazy-loaded or otherwise). You can use my sample repo as a starter. The error has not changed from the one initially posted.

vikerman · 2017-10-27T21:36:50Z

@CaerusKaru - hey - I think we started using this bug to track the factory.create error because we started seeing that in the universal starter.

We will look into the original 'Module not Found' issue.

hansl · 2017-10-30T22:02:09Z

Duplicate of angular/angular#20031

hansl · 2017-10-30T22:02:40Z

Please follow the discussion over the other issue, as this is an issue from Angular's own ngc, which has a fix already in flight. Thanks!

CaerusKaru · 2017-10-31T00:11:09Z

Thanks to everyone on this issue for tracking this down and getting a fix out so quickly. You all rock!

angular-automatic-lock-bot · 2019-09-07T14:41:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Brocco assigned filipesilva Oct 3, 2017

Brocco added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity3: broken labels Oct 3, 2017

filipesilva assigned Brocco and unassigned filipesilva Oct 24, 2017

elvisbegovic mentioned this issue Oct 26, 2017

No NgModule metadata found for 'function (){}'. #8193

Closed

hansl added this to the v1.5.0 milestone Oct 27, 2017

hansl assigned vikerman Oct 28, 2017

vikerman mentioned this issue Oct 30, 2017

Creating a server bundle with CLI results in bundle with require statements to .ngfactory files angular/angular#20031

Closed

hansl marked this as a duplicate of angular/angular#20031 Oct 30, 2017

hansl closed this as completed Oct 30, 2017

angular-automatic-lock-bot bot unassigned Brocco Sep 7, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug(commonjs): erroneous ngfactory #7910

bug(commonjs): erroneous ngfactory #7910

CaerusKaru commented Oct 3, 2017 •

edited

Loading

CaerusKaru commented Oct 24, 2017

filipesilva commented Oct 24, 2017

CaerusKaru commented Oct 24, 2017

filipesilva commented Oct 24, 2017

hansl commented Oct 25, 2017

MarkPieszak commented Oct 26, 2017

CaerusKaru commented Oct 26, 2017 •

edited

Loading

CaerusKaru commented Oct 26, 2017

CaerusKaru commented Oct 26, 2017

vikerman commented Oct 26, 2017

hansl commented Oct 26, 2017

CaerusKaru commented Oct 27, 2017

Toxicable commented Oct 27, 2017

CaerusKaru commented Oct 27, 2017

vikerman commented Oct 27, 2017

hansl commented Oct 30, 2017

hansl commented Oct 30, 2017

CaerusKaru commented Oct 31, 2017

angular-automatic-lock-bot bot commented Sep 7, 2019

bug(commonjs): erroneous ngfactory #7910

bug(commonjs): erroneous ngfactory #7910

Comments

CaerusKaru commented Oct 3, 2017 • edited Loading

Bug Report or Feature Request (mark with an x)

Versions.

Repro steps.

The log given by the failure.

Desired functionality.

Mention any other details that might be useful.

CaerusKaru commented Oct 24, 2017

filipesilva commented Oct 24, 2017

CaerusKaru commented Oct 24, 2017

filipesilva commented Oct 24, 2017

hansl commented Oct 25, 2017

MarkPieszak commented Oct 26, 2017

CaerusKaru commented Oct 26, 2017 • edited Loading

CaerusKaru commented Oct 26, 2017

CaerusKaru commented Oct 26, 2017

vikerman commented Oct 26, 2017

hansl commented Oct 26, 2017

CaerusKaru commented Oct 27, 2017

Toxicable commented Oct 27, 2017

CaerusKaru commented Oct 27, 2017

vikerman commented Oct 27, 2017

hansl commented Oct 30, 2017

hansl commented Oct 30, 2017

CaerusKaru commented Oct 31, 2017

angular-automatic-lock-bot bot commented Sep 7, 2019

CaerusKaru commented Oct 3, 2017 •

edited

Loading

Bug Report or Feature Request (mark with an `x`)

CaerusKaru commented Oct 26, 2017 •

edited

Loading