Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@ngtools/webpack): Handle factory files for the LAZY_MODULE_MAP #8157

Merged
merged 1 commit into from
Oct 23, 2017
Merged

fix(@ngtools/webpack): Handle factory files for the LAZY_MODULE_MAP #8157

merged 1 commit into from
Oct 23, 2017

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Oct 23, 2017 •
edited by hansl
Loading

Fixes: #7901

filipesilva
filipesilva previously requested changes Oct 23, 2017
View reviewed changes
packages/@ngtools/webpack/src/transformers/export_lazy_module_map.spec.ts Outdated
@@ -27,4 +27,28 @@ describe('@ngtools/webpack transformers', () => {
expect(oneLine`${result}`).toEqual(oneLine`${output}`);
});
});

fit('should create module map for AOT', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fit -> it

@Brocco Brocco force-pushed the lazy-module-map-fix branch from 993019e to 507766b Compare October 23, 2017 22:43
@hansl hansl dismissed filipesilva’s stale review October 23, 2017 23:39

Filipe is asleep.

@hansl hansl merged commit ca5e18c into angular:master Oct 23, 2017
@dottodot
Copy link

The previous error has gone but now lazy loading doesn't work at all even just using ng serve an no ssr and I'm getting the following errors

main.5f77e4d9d02c9999acb7.bundle.js:1 ERROR Error: Uncaught (in promise): Error: Cannot find module './home/home.module.ngfactory'.
Error: Cannot find module './home/home.module.ngfactory'.
    at r (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.LMZF.t.loadFactory (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.LMZF.t.load (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.UHIZ.t.loadModuleFactory (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.UHIZ.t.load (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e.project (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e._tryNext (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e._next (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e.E9/g.e.next (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e._subscribe (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at r (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.LMZF.t.loadFactory (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.LMZF.t.load (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.UHIZ.t.loadModuleFactory (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.UHIZ.t.load (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e.project (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e._tryNext (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e._next (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e.E9/g.e.next (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at e._subscribe (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at s (polyfills.d395d19b43173518fc38.bundle.js:1)
    at s (polyfills.d395d19b43173518fc38.bundle.js:1)
    at polyfills.d395d19b43173518fc38.bundle.js:1
    at t.invokeTask (polyfills.d395d19b43173518fc38.bundle.js:1)
    at Object.onInvokeTask (main.5f77e4d9d02c9999acb7.bundle.js:1)
    at t.invokeTask (polyfills.d395d19b43173518fc38.bundle.js:1)
    at r.runTask (polyfills.d395d19b43173518fc38.bundle.js:1)
    at i (polyfills.d395d19b43173518fc38.bundle.js:1)
    at e.invokeTask [as invoke] (polyfills.d395d19b43173518fc38.bundle.js:1)
    at f (polyfills.d395d19b43173518fc38.bundle.js:1)

@filipesilva filipesilva mentioned this pull request Oct 24, 2017
Closed
@Brocco Brocco deleted the lazy-module-map-fix branch April 3, 2018 13:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl hansl approved these changes

@filipesilva filipesilva filipesilva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LAZY_MODULE_MAP not working in 1.5.0
5 participants
@Brocco @dottodot @hansl @filipesilva @googlebot