Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): add profile option to browser builder #11497

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

filipesilva
Copy link
Contributor

This should help users send us profile logs for builds that take too long.

Blocked on #11488 due to webpack/webpack#7450.

package.json Outdated
@@ -125,6 +125,7 @@
"source-map": "^0.5.6",
"source-map-loader": "^0.2.3",
"source-map-support": "^0.5.0",
"speed-measure-webpack-plugin": "^1.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the new webpack/lib/debug/ProfilingPlugin instead of installing a new package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does both actually.

Copy link
Contributor

@hansl hansl Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does speed-measure-webpack-plugin does that ProfilingPlugin doesn't? I don't want to add an additional dependency if there's little to no benefit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProfilingPlugin gives you a chrome perf profile, while SpeedMeasurePlugin gives you total aggregated time per plugin and loader.

It's hard to get that overview with just ProfilingPlugin because the events not necessarily together.

Loaders, for instance, can have many tiny events all over the place, that can add up quickly.

The API to consume SpeedMeasurePlugin is also easier to parse so we can use it to automatocally track individual plugin and loader performance over time instead of just build time.

I think those are the main differences.

hansl
hansl previously approved these changes Sep 25, 2018
…ilder

This should help users send us profile logs for builds that take too long.
@hansl hansl added the target: major This PR is targeted for the next major release label Sep 26, 2018
@hansl hansl merged commit 048366b into angular:master Sep 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants