Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CliConfig): allow set on array item properties #1800

Closed
wants to merge 1 commit into from

Conversation

platosha
Copy link

Support changing properties of array items in CliConfig.set method.
This makes the following commands to work:

  • $ ng set apps[0].main my-main.ts
  • $ ng set apps.0.test my-test.ts

Closes #1763

Support changing properties of array items in `CliConfig.set` method.
This makes the following commands to work:
  - `$ ng set apps[0].main my-main.ts`
  - `$ ng set apps.0.test my-test.ts`

Closes angular#1763
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@hansl
Copy link
Contributor

hansl commented Aug 22, 2016

I'm in process of refactoring config, so I won't let that in. My PR should be ready by EOD.

@hansl hansl closed this Aug 22, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng set apps[0].main does not work
3 participants