-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular-devkit/build-angular): add tailwindcss
support for version 3
#22345
Conversation
@@ -4,13 +4,8 @@ import { ng, silentExec } from '../../../utils/process'; | |||
import { expectToFail } from '../../../utils/utils'; | |||
|
|||
export default async function () { | |||
// Tailwind is not supported in Node.js 10 | |||
if (process.version.startsWith('v10')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is ok to remove because we don't support Node v10 in Angular CLI v13.1.x? Slightly unrelated: Have we explicitly documented our Node support anywhere? Best I could find was on our getting started page, but I'm not sure if that applies to all CLI versions, and I know we care about Node minor releases in some instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed that is the only place we list the node versions that we support. I think they could be better listed in table or something like that.
Re Node 10, we don’t support this since v12
I wonder if that's all what should be covered 🤔 Since Angular moved to ESM modules imports in @import "tailwindcss/base";
@import "tailwindcss/components";
@import "tailwindcss/utilities"; module.exports = {
prefix: '',
content: ['./{libs,apps}/**/*.{html,ts,scss}'],
darkMode: 'class',
theme: {},
plugins: [],
};
I did find TailwindCSS ESM support: tailwindlabs/tailwindcss#3181. Changing |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.