-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular-devkit/schematics): use web standard error check for Deno support #27570
Conversation
Thank you for the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you forgot to put @
before angular
in the commit message scope.
Oops, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit replaces non-standard
e.code
check forTextDecoder.decode
toTypeError
.This matches with other uses of TextDecoder.decode in this codebase, eg:
angular-cli/packages/angular_devkit/schematics/src/tree/host-tree.ts
Line 307 in 4e923fa
Enables
@angular/cli
to run on Deno. Ref denoland/deno#22607