Add possibility to pass i18n options to Webpack Aot Plugin

[tobiasviehweger]

Hi,

since angular-cli does not support the following combination as of now, we needed a workaround:

• AOT with Webpack + I18N

We are now using webpack (raw) with the AotPlugin, though we needed to pass through the i18n options, which was not possible before.

I'm not sure if this is relevant or interesting, just in case, here are my changes - feel free to reject if you don't think this will benefit anyone else :)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[tobiasviehweger]

I signed it!

[googlebot]

CLAs look good, thanks!

[hansl]

The change looks great and I'd like to get this in, but linting and building is failing. Could you fix those?

Also, I'm going to request an End-to-End test for this change if possible. Can be something relatively simple. You can use the already existing test project or create your own (follow the one in assets).

Thanks a lot!

[shaneog]

@tobiasviehweger This would be helpful to me right now, any chance you could clean this up? Or would you like me to open a new PR?

[tobiasviehweger]

@shaneog @hansl Sorry, have been quite busy the last few days, I'll try to clean this up in the morning!

[shaneog]

Thanks @tobiasviehweger, ~~~it would be awesome if we could pass these parameters via the build command also, e.g. ng build --aot --i18nFile=messages.de.xlf --locale=de -prod~~~

Edit: It looks like there is another PR #3098 for the command line options

[tobiasviehweger]

@shaneog @hansl It seems #3098 already contains the changes I made too, just a little different. Probably be best to close this one?

[filipesilva]

Closed as superseded by #3098

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}