Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular/cli): followup changes to circular dependency detection #6843

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

filipesilva
Copy link
Contributor

Flag is now positive instead of negative and shorter, and can now be set on commands as well (--show-circular-dependencies).

Dependency was also added to eject as per #6813 (comment).

@filipesilva
Copy link
Contributor Author

@hansl sorry for the spam (#6839, #6840, #6842), github/travis/appveyor seem to be having some trouble with this PR for some reason.

Flag is now positive instead of negative and shorter, and can now be set on commands as well (`--show-circular-dependencies`).

Dependency was also added to eject as per angular#6813 (comment).
@filipesilva filipesilva force-pushed the circular-dep-followup-two branch from c69b4d4 to 88d0882 Compare June 29, 2017 16:30
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hansl hansl merged commit 28e4114 into angular:master Jun 29, 2017
@filipesilva filipesilva deleted the circular-dep-followup-two branch June 29, 2017 18:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants