This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Unnecessary 32-bit JVM requirement #1765
Comments
kimpettersen
added a commit
to kimpettersen/angular.js
that referenced
this issue
Jan 7, 2013
is there a way to autodetect if 32bit vm is present? building angular with 32bit vm is twice as fast as with 64bit vm |
Sure. Just run: If you get something like: Error: This Java instance does not support a 32-bit JVM. (I suspect the process exits non-zero) then you have your answer. |
Duplicate of #1719 |
I'll be happy to add this to the build once #1544 lands. I'm already conditionally using the -d32 flag on non-windows envs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The Rakefile for angular.js passes -d32 to the java command, making it impossible to build angular.js on a machine which only has 64-bit Java on it. If the argument is removed, it builds fine.
This is very annoying if your project uses angular.js by including it as a git submodule, and you build on Linux where you very well may not have 32-bit JVM.
Seems harmless to remove it at least for building unless something I don't know about is using JNI or something.
The text was updated successfully, but these errors were encountered: