This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Blank line at top of view seems to break <= ie8 in 1.0.4 #1968
Comments
|
@nawlbergs what do you mean by 'at the top of a view'? Could you provide reproduce live scenario (plunker)? |
|
@nawlbergs: Are you using JQuery? I would guess this might be related to this issue: #1876? As per the comments on that ticket, 1.0.4 introduced a regression where IE8 and lower try to set data against text nodes. |
|
Yea... I tried to replicate the issue in plunker... but couldn't. I can try to replicate this again in my actual project... then remove jquery from it and see whats up. |
|
|
|
i should note that it breaks ie8 and below.. not below ie 8.... my titles wrong. |
Merged
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this issue
Feb 18, 2013
…ext nodes The change to prevent <span> elements being wrapped around empty text nodes caused these empty text nodes to have scopes and controllers attached, through jqLite.data() calls, which led to memory leaks and errors in IE8. Now we exclude all but document nodes and elements from having jqLite.data() set both in the compiler and in ng-view. Fixes: angular#1968 and angular#1876
petebacondarwin
added a commit
that referenced
this issue
Feb 18, 2013
…ext nodes The change to prevent <span> elements being wrapped around empty text nodes caused these empty text nodes to have scopes and controllers attached, through jqLite.data() calls, which led to memory leaks and errors in IE8. Now we exclude all but document nodes and elements from having jqLite.data() set both in the compiler and in ng-view. Fixes: #1968 and #1876
|
Should be fixed in 791804b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Putting a blank line at the top of a view with 1.0.4 seems to completely break ie7 and ie8.
The text was updated successfully, but these errors were encountered: