fix(router): throw an error when navigate to null/undefined path #13384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Jan 5, 2017
| @@ -558,6 +559,15 @@ export class Router { | |||
| } | |||
| } | |||
|
|
|||
| private validateCommands(commands: string[]): void { | |||
| for (let i = 0; i < commands.length; i++) { | |||
There was a problem hiding this comment.
commands.forEach(cmd, i => ...
`... contains ${cmd} at index ${i}...`There was a problem hiding this comment.
forEach skips undefined elements
There was a problem hiding this comment.
Ah right it would skip holes... (but not undefined els) I guess a for is better then.
vicb
reviewed
Jan 5, 2017
| @@ -558,6 +559,15 @@ export class Router { | |||
| } | |||
| } | |||
|
|
|||
| private validateCommands(commands: string[]): void { | |||
There was a problem hiding this comment.
make a function outside of the class. Thanks
vicb
added
action: cleanup
DzmitryShylovich
force-pushed
the
gh/10560
branch
2 times, most recently
from
946b86b to
9165d39
Compare
vicb
added
action: merge
DzmitryShylovich
force-pushed
the
gh/10560
branch
from
9165d39 to
610b7ac
Compare
vicb
added
action: merge
DzmitryShylovich
force-pushed
the
gh/10560
branch
from
610b7ac to
b12efa1
Compare
matsko
pushed a commit
that referenced
this pull request
Jan 9, 2017
|
The v4 commit is 46cb04d |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
idlechara
pushed a commit
to idlechara/angular
that referenced
this pull request
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10560