refactor: move resize observer to private cdk entrypoint

angular · Nov 22, 2022 · b4870f9 · b4870f9
1 parent ec56430
commit b4870f9
Show file tree

Hide file tree

Showing 8 changed files with 57 additions and 23 deletions.
diff --git a/src/cdk/config.bzl b/src/cdk/config.bzl
@@ -13,6 +13,7 @@ CDK_ENTRYPOINTS = [
     "listbox",
     "menu",
     "observers",
+    "observers/private",
     "overlay",
     "platform",
     "portal",

diff --git a/src/cdk/observers/private/BUILD.bazel b/src/cdk/observers/private/BUILD.bazel
@@ -0,0 +1,44 @@
+load(
+    "//tools:defaults.bzl",
+    "ng_module",
+    "ng_test_library",
+    "ng_web_test_suite",
+)
+
+package(default_visibility = ["//visibility:public"])
+
+ng_module(
+    name = "private",
+    srcs = glob(
+        ["**/*.ts"],
+        exclude = ["**/*.spec.ts"],
+    ),
+    deps = [
+        "//src:dev_mode_types",
+        "//src/cdk/platform",
+        "@npm//rxjs",
+    ],
+)
+
+ng_test_library(
+    name = "private_tests_lib",
+    srcs = glob(
+        ["**/*.spec.ts"],
+        exclude = ["**/*.e2e.spec.ts"],
+    ),
+    deps = [
+        ":private",
+    ],
+)
+
+ng_web_test_suite(
+    name = "unit_tests",
+    deps = [
+        ":private_tests_lib",
+    ],
+)
+
+filegroup(
+    name = "source-files",
+    srcs = glob(["**/*.ts"]),
+)
diff --git a/src/cdk/observers/private/index.ts b/src/cdk/observers/private/index.ts
@@ -0,0 +1,9 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+export * from './shared-resize-observer';
diff --git a/...form-field/shared-resize-observer.spec.ts → ...rs/private/shared-resize-observer.spec.ts b/...form-field/shared-resize-observer.spec.ts → ...rs/private/shared-resize-observer.spec.ts
diff --git a/...rial/form-field/shared-resize-observer.ts → ...servers/private/shared-resize-observer.ts b/...rial/form-field/shared-resize-observer.ts → ...servers/private/shared-resize-observer.ts
diff --git a/src/material/form-field/BUILD.bazel b/src/material/form-field/BUILD.bazel
@@ -2,8 +2,6 @@ load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_module",
-    "ng_test_library",
-    "ng_web_test_suite",
     "sass_binary",
     "sass_library",
 )
@@ -20,7 +18,7 @@ ng_module(
     deps = [
         "//src:dev_mode_types",
         "//src/cdk/bidi",
-        "//src/cdk/observers",
+        "//src/cdk/observers/private",
         "//src/cdk/platform",
         "//src/material/core",
         "@npm//@angular/forms",
@@ -81,21 +79,3 @@ filegroup(
     name = "source-files",
     srcs = glob(["**/*.ts"]),
 )
-
-ng_test_library(
-    name = "form_field_tests_lib",
-    srcs = glob(
-        ["**/*.spec.ts"],
-        exclude = ["**/*.e2e.spec.ts"],
-    ),
-    deps = [
-        ":form-field",
-    ],
-)
-
-ng_web_test_suite(
-    name = "unit_tests",
-    deps = [
-        ":form_field_tests_lib",
-    ],
-)
diff --git a/src/material/form-field/directives/floating-label.ts b/src/material/form-field/directives/floating-label.ts
@@ -16,7 +16,7 @@ import {
   OnDestroy,
   Output,
 } from '@angular/core';
-import {SharedResizeObserver} from '../shared-resize-observer';
+import {SharedResizeObserver} from '@angular/cdk/observers/private';
 import {Subscription} from 'rxjs';
 
 /**

diff --git a/tools/public_api_guard/BUILD.bazel b/tools/public_api_guard/BUILD.bazel
@@ -9,7 +9,7 @@ generate_test_targets(
         [
             "//src/cdk",
             "//src/material",
-        ] + ["//src/cdk/%s" % e for e in CDK_ENTRYPOINTS] +
+        ] + ["//src/cdk/%s" % e for e in CDK_ENTRYPOINTS if not e.endswith("/private")] +
         ["//src/material/%s" % e for e in MATERIAL_ENTRYPOINTS + MATERIAL_TESTING_ENTRYPOINTS],
 )