Skip to content

Commit

Permalink
fix scroll dispatcher circular dep
Browse files Browse the repository at this point in the history
  • Loading branch information
jelbourn committed Apr 28, 2017
1 parent cc8977c commit fe3a57d
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 17 deletions.
3 changes: 1 addition & 2 deletions src/lib/core/overlay/overlay-directives.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,10 @@ import {
import {PortalModule} from '../portal/portal-directives';
import {ConnectedPositionStrategy} from './position/connected-position-strategy';
import {Dir, LayoutDirection} from '../rtl/dir';
import {Scrollable} from './scroll/scrollable';
import {coerceBooleanProperty} from '../coercion/boolean-property';
import {ESCAPE} from '../keyboard/keycodes';
import {Subscription} from 'rxjs/Subscription';
import {ScrollDispatchModule} from './scroll/scroll-dispatcher';
import {ScrollDispatchModule} from './scroll/index';


/** Default set of positions for the overlay. Follows the behavior of a dropdown. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {Scrollable} from '../scroll/scrollable';
import {Subscription} from 'rxjs/Subscription';
import {TestBed, inject} from '@angular/core/testing';
import Spy = jasmine.Spy;
import {ScrollDispatchModule} from '../scroll/scroll-dispatcher';
import {ScrollDispatchModule} from '../scroll/index';


// Default width and height of the overlay and origin panels throughout these tests.
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/overlay/position/viewport-ruler.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {ViewportRuler, VIEWPORT_RULER_PROVIDER} from './viewport-ruler';
import {TestBed, inject} from '@angular/core/testing';
import {ScrollDispatchModule} from '../scroll/scroll-dispatcher';
import {ScrollDispatchModule} from '../scroll/index';


// For all tests, we assume the browser window is 1024x786 (outerWidth x outerHeight).
Expand Down
15 changes: 15 additions & 0 deletions src/lib/core/overlay/scroll/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import {NgModule} from '@angular/core';
import {SCROLL_DISPATCHER_PROVIDER} from './scroll-dispatcher';
import {Scrollable} from './scrollable';
import {PlatformModule} from '../../platform/index';

export {Scrollable} from './scrollable';
export {ScrollDispatcher} from './scroll-dispatcher';

@NgModule({
imports: [PlatformModule],
exports: [Scrollable],
declarations: [Scrollable],
providers: [SCROLL_DISPATCHER_PROVIDER],
})
export class ScrollDispatchModule { }
13 changes: 2 additions & 11 deletions src/lib/core/overlay/scroll/scroll-dispatcher.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {NgModule, ElementRef, Injectable, NgZone, Optional, SkipSelf} from '@angular/core';
import {Platform, PlatformModule} from '../../platform/index';
import {ElementRef, Injectable, NgZone, Optional, SkipSelf} from '@angular/core';
import {Platform} from '../../platform/index';
import {Scrollable} from './scrollable';
import {Subject} from 'rxjs/Subject';
import {Observable} from 'rxjs/Observable';
Expand Down Expand Up @@ -143,12 +143,3 @@ export const SCROLL_DISPATCHER_PROVIDER = {
deps: [[new Optional(), new SkipSelf(), ScrollDispatcher], NgZone, Platform],
useFactory: SCROLL_DISPATCHER_PROVIDER_FACTORY
};


@NgModule({
imports: [PlatformModule],
exports: [Scrollable],
declarations: [Scrollable],
providers: [SCROLL_DISPATCHER_PROVIDER],
})
export class ScrollDispatchModule { }
2 changes: 1 addition & 1 deletion src/lib/core/ripple/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {ModuleWithProviders, NgModule} from '@angular/core';
import {MdRipple} from './ripple';
import {MdCommonModule} from '../common-behaviors/common-module';
import {VIEWPORT_RULER_PROVIDER} from '../overlay/position/viewport-ruler';
import {ScrollDispatchModule} from '../overlay/scroll/scroll-dispatcher';
import {ScrollDispatchModule} from '../overlay/scroll/index';
import {PlatformModule} from '../platform/index';

export {MdRipple, RippleGlobalOptions, MD_RIPPLE_GLOBAL_OPTIONS} from './ripple';
Expand Down
2 changes: 1 addition & 1 deletion src/lib/tabs/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {MdInkBar} from './ink-bar';
import {MdTabBody} from './tab-body';
import {VIEWPORT_RULER_PROVIDER} from '../core/overlay/position/viewport-ruler';
import {MdTabHeader} from './tab-header';
import {ScrollDispatchModule} from '../core/overlay/scroll/scroll-dispatcher';
import {ScrollDispatchModule} from '../core/overlay/scroll/index';


@NgModule({
Expand Down

0 comments on commit fe3a57d

Please sign in to comment.