Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatSelectionList initial value not working with OnPush #10090

Closed
Manduro opened this issue Feb 22, 2018 · 1 comment · Fixed by #10100
Closed

MatSelectionList initial value not working with OnPush #10090

Manduro opened this issue Feb 22, 2018 · 1 comment · Fixed by #10100
Assignees
@crisbeto @devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Manduro
Copy link

Manduro commented Feb 22, 2018 •
edited
Loading

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When using a MatSelectionList with a FormControl, the initial value of the FormControl should be represented in the page.

What is the current behavior?

The initial value is not represented on the page. Options that should be selected are not.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-elknpg?file=app/list-selection-example.ts
(toggle the line with ChangeDetectionStrategy)

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Any

Is there anything else we should know?

Great quality library, keep it up!!
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Feb 22, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 22, 2018
@crisbeto
fix(selection-list): repeated preselected items not appearing as sele…
3b3f9fc 
…cted with OnPush parent

Fixes preselected options, rendered with via `NgFor`, inside a component with `OnPush` change detection, not appearing as selected.

Fixes angular#10090.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 22, 2018
@crisbeto
fix(selection-list): repeated preselected items not appearing as sele…
46be3a6 
…cted with OnPush parent

Fixes preselected options, rendered with via `NgFor`, inside a component with `OnPush` change detection, not appearing as selected.

Fixes angular#10090.
@crisbeto crisbeto mentioned this issue Feb 22, 2018
Merged
jelbourn pushed a commit that referenced this issue Feb 26, 2018
@crisbeto @jelbourn
fix(selection-list): repeated preselected items not appearing as sele…
cdd224a 
…cted with OnPush parent (#10100)

Fixes preselected options, rendered with via `NgFor`, inside a component with `OnPush` change detection, not appearing as selected.

Fixes #10090.
mmalerba pushed a commit to mmalerba/components that referenced this issue Feb 26, 2018
@crisbeto @mmalerba
fix(selection-list): repeated preselected items not appearing as sele…
75c6195 
…cted with OnPush parent (angular#10100)

Fixes preselected options, rendered with via `NgFor`, inside a component with `OnPush` change detection, not appearing as selected.

Fixes angular#10090.
jelbourn pushed a commit to jelbourn/components that referenced this issue Feb 27, 2018
@crisbeto @jelbourn
fix(selection-list): repeated preselected items not appearing as sele…
f93d0f4 
…cted with OnPush parent (angular#10100)

Fixes preselected options, rendered with via `NgFor`, inside a component with `OnPush` change detection, not appearing as selected.

Fixes angular#10090.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
3 participants
@Manduro @crisbeto @devversion