Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling ripple globally doesn't work globally #11847

Closed
kevinbeal opened this issue Jun 19, 2018 · 1 comment · Fixed by #11865
Closed

Disabling ripple globally doesn't work globally #11847

kevinbeal opened this issue Jun 19, 2018 · 1 comment · Fixed by #11865
Assignees
@devversion

Comments

@kevinbeal
Copy link

kevinbeal commented Jun 19, 2018 •
edited
Loading

Bug, feature request, or proposal:

feature request

What is the expected behavior?

That when I add the provider {provide: MAT_RIPPLE_GLOBAL_OPTIONS, useValue: {disabled: true}} that it would disable the ripple on more than just buttons.

What is the current behavior?

The ripple is not disabled on the tab-nav-bar. In the source file nothing is done with the disabled property.

What are the steps to reproduce?

https://angular-material2-issue-yhgxqa.stackblitz.io

What is the use-case or motivation for changing an existing behavior?

Don't want the ripple at all in our app, but love everything else.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

TS: 2.8.3
Angular: 6.0.1
Angular Material: latest

Is there anything else we should know?

Can't think of anything.
@devversion devversion self-assigned this Jun 20, 2018
devversion added a commit to devversion/material2 that referenced this issue Jun 20, 2018
@devversion
fix(tab-nav-bar): ripples still showing up when globally disabled
7e5f499 
* If someone disables the ripples globally using the `MAT_RIPPLE_GLOBAL_OPTIONS`, the `<mat-tab-nav-bar>` still shows ripples. Ripples should be disabled for that custom `RippleTarget` as well.
* By cloning and reinstalling the whole project, I ran into a runtime exception when running Gulp

Fixes angular#11847
@devversion devversion mentioned this issue Jun 20, 2018
Merged
devversion added a commit to devversion/material2 that referenced this issue Jun 25, 2018
@devversion
fix(chips): ripples still showing up when globally disabled
2bd3e3c 
* If someone disables the ripples globally using the `MAT_RIPPLE_GLOBAL_OPTIONS`, chips will still shows ripples. Ripples should be disabled for that custom `RippleTarget` as well.

References angular#11847
@devversion devversion mentioned this issue Jun 25, 2018
Merged
devversion added a commit to devversion/material2 that referenced this issue Jun 27, 2018
@devversion
fix(tab-nav-bar): ripples still showing up when globally disabled
c30ea86 
* If someone disables the ripples globally using the `MAT_RIPPLE_GLOBAL_OPTIONS`, the `<mat-tab-nav-bar>` still shows ripples. Ripples should be disabled for that custom `RippleTarget` as well.
* By cloning and reinstalling the whole project, I ran into a runtime exception when running Gulp

Fixes angular#11847
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tab-nav-bar): ripples still showing up when globally disabled devversion/material2
2 participants
@kevinbeal @devversion