Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mat-card mat-divider] [bug] make mat-divider css more specific or isolate #11895

Closed
wilker7ribeiro opened this issue Jun 22, 2018 · 1 comment · Fixed by #11899
Closed

[mat-card mat-divider] [bug] make mat-divider css more specific or isolate #11895

wilker7ribeiro opened this issue Jun 22, 2018 · 1 comment · Fixed by #11899
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@wilker7ribeiro
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

mat-divider CSS from mat-card should not have influence in mat-dividers inside mat-card-content

What is the current behavior?

All mat-dividers inherit's this CSS above, breaking their behavior (0px height)

.mat-card .mat-divider {
    position: absolute;
    left: 0;
    width: 100%;
}

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue-tml6fe

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

@angular/[email protected]
@angular/[email protected]
@crisbeto crisbeto self-assigned this Jun 23, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jun 23, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 23, 2018
@crisbeto
fix(card): don't override vertical divider styles
f97f260 
Currently `mat-card` has some overrides for the `mat-divider` styling, however it assumes that all dividers will be horizontal, which ends up breaking the styling for vertical dividers. These changes target the style overrides only to horizontal dividers.

Fixes angular#11895.
@crisbeto crisbeto mentioned this issue Jun 23, 2018
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(card): don't override vertical divider styles crisbeto/material2
2 participants
@crisbeto @wilker7ribeiro