Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mat-tab-group with mat-stretch-tabs stretches tab groups inside it #12196

Closed
xernobyl opened this issue Jul 13, 2018 · 1 comment · Fixed by #12198
Closed

mat-tab-group with mat-stretch-tabs stretches tab groups inside it #12196

xernobyl opened this issue Jul 13, 2018 · 1 comment · Fixed by #12198
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@xernobyl
Copy link

Bug, feature request, or proposal:

When adding a mat-tab-group inside a mat-tab-group with mat-stretch-tabs it behaves as if if it has mat-stretch-tabs.

What is the expected behavior?

A mat-tab-group inside a stretching mat-tab-group with mat-stretch-tabs shouldn't stretch.

What is the current behavior?

A mat-tab-group inside a stretching mat-tab-group with mat-stretch-tabs stretches.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue

What is the use-case or motivation for changing an existing behavior?

TABCEPTION

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

6.3.3

Is there anything else we should know?

No, you're smart.
@xernobyl xernobyl changed the title mat-stretch-tabs works across multiple tab groups mat-tab-group with mat-stretch-tabs stretches tab groups inside it Jul 13, 2018
@crisbeto crisbeto self-assigned this Jul 13, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 13, 2018
@crisbeto
fix(tabs): only target direct descendants with mat-stretch-tabs
8076d9a 
Fixes `mat-stretch-tabs` applying to all descendant tab headers, rather than direct descendants only.

Fixes angular#12196.
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Jul 13, 2018
@crisbeto crisbeto mentioned this issue Jul 13, 2018
Merged
jelbourn pushed a commit that referenced this issue Aug 23, 2018
@crisbeto @jelbourn
fix(tabs): only target direct descendants with mat-stretch-tabs
81e9dd0 
Fixes `mat-stretch-tabs` applying to all descendant tab headers, rather than direct descendants only.

Fixes #12196.
jelbourn pushed a commit that referenced this issue Aug 23, 2018
@crisbeto @jelbourn
fix(tabs): only target direct descendants with mat-stretch-tabs (#12198)
592af48 
Fixes `mat-stretch-tabs` applying to all descendant tab headers, rather than direct descendants only.

Fixes #12196.
jelbourn pushed a commit that referenced this issue Aug 29, 2018
@crisbeto @jelbourn
fix(tabs): only target direct descendants with mat-stretch-tabs (#12198)
6bb0ffe 
Fixes `mat-stretch-tabs` applying to all descendant tab headers, rather than direct descendants only.

Fixes #12196.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): only target direct descendants with mat-stretch-tabs crisbeto/material2
2 participants
@xernobyl @crisbeto