Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor memory leak in cdk table #12259

Closed
FDIM opened this issue Jul 18, 2018 · 1 comment · Fixed by #12269
Closed

minor memory leak in cdk table #12259

FDIM opened this issue Jul 18, 2018 · 1 comment · Fixed by #12269
Assignees
@crisbeto @andrewseguin
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent perf This issue is related to performance

Comments

@FDIM
Copy link

FDIM commented Jul 18, 2018 •
edited
Loading

Bug, feature request, or proposal:

Shouldn't static member be reset to null when all outlets are destroyed?

What is the expected behavior?

No memory leak

What is the current behavior?

Minor memory leak via mostRecentCellOutlet property in CdkCellOutlet

What are the steps to reproduce?

I hope screenshot below is enough to show case this

What is the use-case or motivation for changing an existing behavior?

To save some memory as it holds last outlet reference which potentially could have bigger impact. In my case actual component instance is not released because of this.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

CDK v6.3.3

Is there anything else we should know?

Heap snapshot in chrome:
image
@josephperrott josephperrott added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent perf This issue is related to performance labels Jul 18, 2018
@crisbeto crisbeto self-assigned this Jul 18, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 18, 2018
@crisbeto
perf(table): leaking reference through mostRecentCellOutlet
981d740 
Fixes the table leaking out a reference to a cell outlet via the `CdkCellOutlet.mostRecentCellOutlet` after all tables have been destroyed.

Fixes angular#12259.
@crisbeto crisbeto mentioned this issue Jul 18, 2018
Merged
mmalerba pushed a commit that referenced this issue Jul 29, 2018
@crisbeto @mmalerba
perf(table): leaking reference through mostRecentCellOutlet (#12269)
34a7e38 
Fixes the table leaking out a reference to a cell outlet via the `CdkCellOutlet.mostRecentCellOutlet` after all tables have been destroyed.

Fixes #12259.
mmalerba pushed a commit that referenced this issue Jul 30, 2018
@crisbeto @mmalerba
perf(table): leaking reference through mostRecentCellOutlet (#12269)
7c8e892 
Fixes the table leaking out a reference to a cell outlet via the `CdkCellOutlet.mostRecentCellOutlet` after all tables have been destroyed.

Fixes #12259.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

@andrewseguin andrewseguin

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent perf This issue is related to performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(table): leaking reference through mostRecentCellOutlet crisbeto/material2
4 participants
@FDIM @crisbeto @josephperrott @andrewseguin