Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatProgressBar _rectangleFillValue didn't display when routing is using hash #12710

Closed
Eusen opened this issue Aug 17, 2018 · 4 comments · Fixed by #12713
Closed

MatProgressBar _rectangleFillValue didn't display when routing is using hash #12710

Eusen opened this issue Aug 17, 2018 · 4 comments · Fixed by #12713
Assignees
@crisbeto
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@Eusen
Copy link

Eusen commented Aug 17, 2018

It‘s a Bug:

<mat-progress-bar [mode]='buffer'>

image

In the official website, it is normal.
but in my site:

image

u see, it’s blank!!!
In my router config, useHash is true, so my url is like: http://localhost:9621/#/preview/home
This is the only point different from the official website.

I found the bug:
image
If I adjust it as follows:
image
image
It's worked!

What is the expected behavior?

To normal.

What is the current behavior?

MatProgressBar buffer mode is blank.
@crisbeto crisbeto self-assigned this Aug 17, 2018
@Eusen
Copy link
Author

Eusen commented Aug 17, 2018

I also don't understand why the progress bar in query mode is static.
280e745ed2930f69cea5085358de6c4

@jotatoledo
Copy link

query mode is currently broken, was solved by #11459

Should be released on next patch most likely

@Eusen
Copy link
Author

Eusen commented Aug 17, 2018

query mode is likely indeterminate mode, if just set:

.mat-progress-bar[mode=query] {
   transform: scale(-1);
}

it's simple to implement

crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 17, 2018
@crisbeto
fix(progress-bar): incorrectly handling current path when using hash …
62b7288 
…location strategy

Fixes the progress bar prefixing the references incorrectly when the consumer is using the router's hash location strategy. The issue comes from the fact that the router normalizes the `location.pathname` between the regular strategy and the hash one, whereas we need to use the exact same path as the `window.location`.

Fixes angular#12710.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround has pr labels Aug 17, 2018
@crisbeto crisbeto mentioned this issue Aug 17, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 21, 2018
@crisbeto
fix(progress-bar): incorrectly handling current path when using hash …
a3f5206 
…location strategy

Fixes the progress bar prefixing the references incorrectly when the consumer is using the router's hash location strategy. The issue comes from the fact that the router normalizes the `location.pathname` between the regular strategy and the hash one, whereas we need to use the exact same path as the `window.location`.

Fixes angular#12710.
jelbourn pushed a commit that referenced this issue Aug 22, 2018
@crisbeto @jelbourn
fix(progress-bar): incorrectly handling current path when using hash …
5727eac 
…location strategy (#12713)

Fixes the progress bar prefixing the references incorrectly when the consumer is using the router's hash location strategy. The issue comes from the fact that the router normalizes the `location.pathname` between the regular strategy and the hash one, whereas we need to use the exact same path as the `window.location`.

Fixes #12710.
jelbourn pushed a commit that referenced this issue Aug 29, 2018
@crisbeto @jelbourn
fix(progress-bar): incorrectly handling current path when using hash …
da3b5e0 
…location strategy (#12713)

Fixes the progress bar prefixing the references incorrectly when the consumer is using the router's hash location strategy. The issue comes from the fact that the router normalizes the `location.pathname` between the regular strategy and the hash one, whereas we need to use the exact same path as the `window.location`.

Fixes #12710.
@yeputons yeputons mentioned this issue Oct 23, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
3 participants
@crisbeto @Eusen @jotatoledo