Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating labels have no gap in table expandable rows with outline appearance #13328

Closed
Trent-Matthias opened this issue Sep 27, 2018 · 4 comments · Fixed by #13477
Closed

Floating labels have no gap in table expandable rows with outline appearance #13328

Trent-Matthias opened this issue Sep 27, 2018 · 4 comments · Fixed by #13477
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Trent-Matthias
Copy link

Trent-Matthias commented Sep 27, 2018

Bug, feature request, or proposal:

Floating label in mat-form-field is not calculating a gap in expandable rows in a table.

What is the expected behavior?

That the form field gap is calculated like normal

What is the current behavior?

The label floats but no gap appears.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-1brv1b?file=app/table-expandable-rows-example.html

I simply forked the table with expandable rows example from the docs here https://material.angular.io/components/table/examples and added a very simple form field to the expansion panel.

What is the use-case or motivation for changing an existing behavior?

I'd like to have the ability to have a user add a note to a table entry using a text area. I use outline form fields throughout my app and would like to keep the styling for the table.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/material": "^6.4.7"
"typescript": "~2.9.2"
"@angular/core": "^6.1.8"
This issue is in Chrome on Mac

Is there anything else we should know?

This happens even if I comment out the css.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Oct 3, 2018
@crisbeto crisbeto self-assigned this Oct 7, 2018
@crisbeto crisbeto added the has pr label Oct 7, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 7, 2018
… off invisible

Fixes the gaps for a `mat-form-field` with the `outline` appearance not being calculated properly if the element starts off as being invisible and then becomes visible later.

Fixes angular#13328.
@mmalerba
Copy link
Contributor

mmalerba commented Oct 7, 2018

This is because of the display: none in your animation, you can see here that removing it fixes the issue: https://stackblitz.com/edit/angular-1brv1b-9dxlbf?file=app/table-expandable-rows-example.ts

crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 18, 2018
… off invisible

Fixes the gaps for a `mat-form-field` with the `outline` appearance not being calculated properly if the element starts off as being invisible and then becomes visible later.

Fixes angular#13328.
@starksds
Copy link

starksds commented Oct 25, 2018

I also see the same issue when wrapping an element with [hidden]
`<div [hidden]="!conditionalShow">
mat form element with outline float always or auto

`

@noggin182
Copy link

I came across this same problem in a different place, here's a simplified example showing how display:none causes this issue:
https://stackblitz.com/edit/angular-bclu9w

vivian-hu-zz pushed a commit that referenced this issue Nov 6, 2018
… off invisible

Fixes the gaps for a `mat-form-field` with the `outline` appearance not being calculated properly if the element starts off as being invisible and then becomes visible later.

Fixes #13328.
mmalerba pushed a commit that referenced this issue Dec 6, 2018
… off invisible (#13477)

Fixes the gaps for a `mat-form-field` with the `outline` appearance not being calculated properly if the element starts off as being invisible and then becomes visible later.

Fixes #13328.
mmalerba pushed a commit that referenced this issue Dec 10, 2018
… off invisible (#13477)

Fixes the gaps for a `mat-form-field` with the `outline` appearance not being calculated properly if the element starts off as being invisible and then becomes visible later.

Fixes #13328.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019
… off invisible (angular#13477)

Fixes the gaps for a `mat-form-field` with the `outline` appearance not being calculated properly if the element starts off as being invisible and then becomes visible later.

Fixes angular#13328.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
6 participants