Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag and drop - spacing gets messed up #13483

Closed
DmitryEfimenko opened this issue Oct 7, 2018 · 2 comments · Fixed by #13849
Closed

drag and drop - spacing gets messed up #13483

DmitryEfimenko opened this issue Oct 7, 2018 · 2 comments · Fixed by #13849
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@DmitryEfimenko
Copy link

Bug, feature request, or proposal:

Please see current behavior

What is the expected behavior?

Spacing of preview element and current elements in the list should not get messed up

What is the current behavior?

Result

Result

What are the steps to reproduce?

StackBlitz

What is the use-case or motivation for changing an existing behavior?

Fix spacing issues

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

7.0.0-rc.0

@crisbeto crisbeto self-assigned this Oct 8, 2018
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Oct 10, 2018
@philmtd
Copy link

philmtd commented Oct 16, 2018

Might be related to this issue: When cdkDrag items in a cdkDropList have different heights the elements animate to a wrong position on drop and the previews are rendered wrong just as in the example above.

crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 28, 2018
… margins

Currently the `CdkDropList` makes some assumptions about the items not having a margin between each other. It also won't lay out and animate items with varying heights, in some cases. The following changes rework the directive to allow it to handle both varying heights and different margins.

Fixes angular#13483.
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 30, 2018
… margins

Currently the `CdkDropList` makes some assumptions about the items not having a margin between each other. It also won't lay out and animate items with varying heights, in some cases. The following changes rework the directive to allow it to handle both varying heights and different margins.

Fixes angular#13483.
jelbourn pushed a commit that referenced this issue Nov 3, 2018
… margins (#13849)

Currently the `CdkDropList` makes some assumptions about the items not having a margin between each other. It also won't lay out and animate items with varying heights, in some cases. The following changes rework the directive to allow it to handle both varying heights and different margins.

Fixes #13483.
atscott pushed a commit to atscott/components that referenced this issue Nov 5, 2018
… margins (angular#13849)

Currently the `CdkDropList` makes some assumptions about the items not having a margin between each other. It also won't lay out and animate items with varying heights, in some cases. The following changes rework the directive to allow it to handle both varying heights and different margins.

Fixes angular#13483.
jelbourn pushed a commit that referenced this issue Nov 6, 2018
… margins (#13849)

Currently the `CdkDropList` makes some assumptions about the items not having a margin between each other. It also won't lay out and animate items with varying heights, in some cases. The following changes rework the directive to allow it to handle both varying heights and different margins.

Fixes #13483.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants