-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool tip material positioning on mobile device #13536
Comments
The tooltip's behavior on mobile depends on the |
You are correct @crisbeto I had not in the committed version. However I had in my local copy (now committed) I have now also embellished the details on the issue and included screenshots on the tooltip docs example to show the same thing. Only on a long page the tooltip is quite often not even visible. |
The positioning issue when the page is scrolled should be fixed by #11628 in Material 7.0. |
Fantastic. Thank you for your prompt response 👍 |
Unlike other components that we use Hammer on, the tooltip won't show up at all on a touch device if Hammer isn't loaded. These changes add a fallback to using a `touchstart` event to trigger the tooltip. Also fixes the `_manualListeners` not being cleared on Android. Fixes angular#13536.
Closing the issue since everything should be working as expected. I've also submitted a PR to add a fallback for pages that don't include Hammer. |
…ngular#13580) Unlike other components that we use Hammer on, the tooltip won't show up at all on a touch device if Hammer isn't loaded. These changes add a fallback to using a `touchstart` event to trigger the tooltip. Also fixes the `_manualListeners` not being cleared on Android. Fixes angular#13536.
newbee question: how can I find version a bug is fixed in github? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug:
After recently upgrading to Angular 6 we have noticed that the default behavior Angular material is no longer functioning as expected.
Works as expected on desktop. However, on mobile when doing a long key press the tool tip does not show in the correct place, In one situation we have managed to hack it adding a click to toggle the tooltip (which is not really ideal as its not the default behaviour). However, where there is a scrollbar the tooltip does not position right by where you click. In most instances it is positioned off screen and (if you are lucky) scrolling down brings the tooltip up and into view. However if it is lower down the tooltip does not appear.
Code to reproduce the issue:
https://github.com/ethan-gforces/material-tooltip
Screenshot showing issue in tooltip example docs
Landscape on iPhone
Portrait on iPhone
Detailed Reproduction Steps:
What is the expected behavior?
With a long keypress (1.5 secs) the first tooltip will display in the correct position
What is the current behavior?
With a long keypress the first tooltip does not display in the correct position
Versions of Angular, Material and browsers are affected?
The text was updated successfully, but these errors were encountered: