-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expansion panel FOUC when contained in dialog #13870
Comments
Might potentially be solved by #11778. |
I tried it out and it doesn't look like it'll be fixed by #11778. |
Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel. Fixes angular#13870.
…13888) Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel. Fixes #13870.
…ngular#13888) Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel. Fixes angular#13870.
…13888) Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel. Fixes #13870.
Reopening as the fix was reverted. This seems to be a larger issue across our library as our components use animations to set state quite frequently. |
@josephperrott I've opened #14127 which should fix the issue and avoid the presubmit issues. |
@crisbeto @josephperrott Hate to be that guy, but has there been any traction on this issue since November? Looks like it might be blocked by a larger issue, per comments in the PR? |
Hope this issue gets the attention it deserves. definitely shouldn't be a "P4" priority. |
Hi guys, It's a workaround but you can use the lazy rendering of the expansion panel to prevent the animation ( with ng-template matExpansionPanelContent). |
@crisbeto @josephperrott, Is there a timeline for this fix being worked into a release? Asking so we know whether to move forward with workarounds or reworks. |
hello! is there an ETA on this? |
Still persist on Angular Material 10.0.1 |
Still persist with Angular Material 11.0.x |
The skackblitz links in the issue are not opening. Here is mine for Angular v11 https://stackblitz.com/edit/components-issue-1fvgvm |
I'm still having this issue as well with Angular Material 11 |
Thanks alot. You Saved the Day. |
I think the problem is inside dialog itself, because I noticed that all content is jumping when dialog is opening. To reproduce that you can open any dialog in angular material dialog example page. The content jumps a little. We have separated dialog header and footer (actions) and now content jumping became very noticeable. At first thought that there is a bug in our project, but then decided to check the material dialog example page. Open this stackblitz: And now open dialog. You will notice how buttons are jumping a little. If you cannot - enable CPU throttling in devtools. |
Same thing happens with an expansion panel inside a mat-menu .. problem still persists |
Still persist with Angular Material 12.0.x |
Also happens when the expansion panel is placed inside a stepper using Angular Material 11.2.13 |
give this issue some attention please. this is serious glitch and I spent so much time thinking I was doing something wrong! but it seems to be there since 2018! |
If this is not fixed yet, please fix it!!! Thank you!!! Had the same problem. With the workaround from @dcrouch79 it works for now. Thanks! |
Reworks several components that usually contain projected content not to block animations within that content. This prevents things like expansion panels from appearing as open. These changes are identical to angular#13888 which had to be reverted in the past. Fixes angular#13870.
Reworks several components that usually contain projected content not to block animations within that content. This prevents things like expansion panels from appearing as open. These changes are identical to angular#13888 which had to be reverted in the past. Fixes angular#13870.
Reworks several components that usually contain projected content not to block animations within that content. This prevents things like expansion panels from appearing as open. These changes are identical to #13888 which had to be reverted in the past. Fixes #13870. (cherry picked from commit 5edcc68)
…r#24529) Reworks several components that usually contain projected content not to block animations within that content. This prevents things like expansion panels from appearing as open. These changes are identical to angular#13888 which had to be reverted in the past. Fixes angular#13870.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a...
Current behavior
Expansion panels currently render with a flash of unstyled content (FOUC) when nested in a dialog -- they always temporarily appear as expanded, regardless of what the "expanded" attribute is set to. After a moment, all expansion panels that have been explicitly set to closed collapse.
This only occurs in Angular / Material 7.
Expected behavior
Expansion panels should appear as collapsed when the dialog opens when
expanded=false
instead of briefly appearing as expanded, then collapsing after a delay.Minimal reproduction of the problem with instructions
Click the button and note the flash of unstyled content in the dialog in Angular 7.
Angular 7 (bugged): https://angular-egzwfw.stackblitz.io
Angular 6 (correct): https://angular-eepzxs.stackblitz.io
What is the motivation / use case for changing the behavior?
Flashes of unstyled content are jarring and feel very buggy.
Environment
The text was updated successfully, but these errors were encountered: