Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Default option values for Expansion Panel Header collapsed/expanded heights #14383

Closed
ghost opened this issue Dec 4, 2018 · 1 comment · Fixed by #14384
Closed
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions

Comments

@ghost
Copy link

ghost commented Dec 4, 2018

Bug, feature request, or proposal:

Possibility to control globally the collapsedHeight and expandedHeight properties of an Expansion Panel Header.

What is the expected behavior?

Similarly to what is currently available for form fields (via MAT_FORM_FIELD_DEFAULT_OPTIONS), if the mat-expansion-panel-header collapsedHeight and expandedHeight properties are available for a global definition (default options), they should be considered for any Expansion Panel Header on the application.
If an Expansion Panel Header explicitly defines any of these properties, then the default values should be overriden.

What is the current behavior?

Not available as of now. Each mat-expansion-panel-header needs to explicitly declare these properties.

What are the steps to reproduce?

N/A

What is the use-case or motivation for changing an existing behavior?

When the Angular Material default values for collapsedHeight and expandedHeight don't meet the application needs, there should be a way to redefine them, reuse them, and consider their values from a global perspective.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Any.

Is there anything else we should know?

N/A

@crisbeto crisbeto self-assigned this Dec 4, 2018
@crisbeto crisbeto added feature This issue represents a new feature or feature request rather than a bug or bug fix has pr P4 A relatively minor issue that is not relevant to core functions labels Dec 4, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 4, 2018
…t options

Adds a new injection token to allow people to configure the default options for the expansion panel component.

Fixes angular#14383.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 4, 2018
…t options

Adds a new injection token to allow people to configure the default options for the expansion panel component.

Fixes angular#14383.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 5, 2018
…t options

Adds a new injection token to allow people to configure the default options for the expansion panel component.

Fixes angular#14383.
jelbourn pushed a commit that referenced this issue Dec 19, 2018
…t options (#14384)

Adds a new injection token to allow people to configure the default options for the expansion panel component.

Fixes #14383.
josephperrott pushed a commit to josephperrott/components that referenced this issue Jan 14, 2019
…t options (angular#14384)

Adds a new injection token to allow people to configure the default options for the expansion panel component.

Fixes angular#14383.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant