Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing margin on stroked buttons in card actions #16546

Closed
CharlBest opened this issue Jul 17, 2019 · 1 comment · Fixed by #16576
Closed

Missing margin on stroked buttons in card actions #16546

CharlBest opened this issue Jul 17, 2019 · 1 comment · Fixed by #16576
Assignees
@crisbeto
Labels
good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions

Comments

@CharlBest
Copy link

CharlBest commented Jul 17, 2019 •
edited
Loading

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Left and right margin should be added to stroked buttons in card actions

What is the current behavior?

No margin is being applied. Only to normal and raised buttons.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-5xgbjx?file=app/button-overview-example.html

What is the use-case or motivation for changing an existing behavior?

Stroke button should have the same behavior as normal and raised buttons in card actions

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 8
Material 8

Is there anything else we should know?

n/a
@andrewseguin andrewseguin added good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions labels Jul 17, 2019
@crisbeto crisbeto self-assigned this Jul 21, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 21, 2019
@crisbeto
fix(card): stroked buttons missing margin
0a079cd 
Fixes stroked buttons inside of card actions not having a margin.

Fixes angular#16546.
@crisbeto crisbeto mentioned this issue Jul 21, 2019
Merged
jelbourn pushed a commit that referenced this issue Aug 27, 2019
@crisbeto @jelbourn
fix(card): stroked buttons missing margin (#16576)
399ed29 
Fixes stroked buttons inside of card actions not having a margin.

Fixes #16546.
mmalerba pushed a commit to mmalerba/components that referenced this issue Aug 27, 2019
@crisbeto @mmalerba
fix(card): stroked buttons missing margin (angular#16576)
459eacf 
Fixes stroked buttons inside of card actions not having a margin.

Fixes angular#16546.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(card): stroked buttons missing margin crisbeto/material2
3 participants
@crisbeto @CharlBest @andrewseguin