-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng-add: option to set up typography styles for native elements #16776
Comments
In the documentation this is mentioned. |
Yes you’re correct. |
@jelbourn Do we actually want to do this as part of |
Seems reasonable as a prompt in |
In
but the |
⬆️ @crisbeto |
In angular#17602 a new prompt to `ng-add` was added which allowed consumers to opt into adding the `mat-typgoraphy` style globally, but it looks like the option was never read so the class is always being added. Fixes angular#16776.
…18315) In angular#17602 a new prompt to `ng-add` was added which allowed consumers to opt into adding the `mat-typgoraphy` style globally, but it looks like the option was never read so the class is always being added. Fixes angular#16776.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Reproduction
Steps to reproduce:
create new angular app
do: ng add @angluar/material
result:
added 3 packages from 4 contributors in 15.766s
UPDATE src/main.ts (391 bytes)
UPDATE src/app/app.module.ts (577 bytes)
UPDATE angular.json (3608 bytes)
UPDATE src/index.html (490 bytes)
UPDATE src/styles.css (181 bytes)
notice that in index.html the fonts links are added but the body tag has no class
Expected Behavior
The schematic should add class="mat-typography" to the body tag in index.html
Actual Behavior
The schematic changes the index.html to add font links but did not change the body tag
Environment
The text was updated successfully, but these errors were encountered: