Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use dragStartDelay only for touch events #17260

Closed
aeslinger0 opened this issue Oct 1, 2019 · 2 comments · Fixed by #17301 or hrueger/AGLight#112
Closed

Option to use dragStartDelay only for touch events #17260

aeslinger0 opened this issue Oct 1, 2019 · 2 comments · Fixed by #17301 or hrueger/AGLight#112
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@aeslinger0
Copy link

Feature Description

Ability to control which events cause dragStartDelay to be used.

Use Case

dragStartDelay works great for touch screen devices to prevent dragging when you meant to scroll, but on the desktop with the mouse it just makes it feel like it's buggy or unresponsive. It'd be great if we had the ability to choose which events it applied to - even better if it defaulted to only applying to touch-screen events.

@aeslinger0 aeslinger0 added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Oct 1, 2019
@crisbeto crisbeto self-assigned this Oct 5, 2019
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent feature This issue represents a new feature or feature request rather than a bug or bug fix and removed feature This issue represents a new feature or feature request rather than a bug or bug fix labels Oct 5, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 5, 2019
…nt type

Allows the consumer to configure the drag start delay based on whether it's a touch event or mouse event.

Fixes angular#17260.
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 5, 2019
…nt type

Allows the consumer to configure the drag start delay based on whether it's a touch event or mouse event.

Fixes angular#17260.
@aeslinger0
Copy link
Author

@crisbeto the PR looks great, exactly what I was looking for. Thanks. We must be getting close to version 9 being released, do you think this will make it in there?

For anyone that needs a workaround until this is released, I use [cdkDragStartDelay]="dragStartDelay" (touchstart)="dragStartDelay = 100" (mousedown)="dragStartDelay = 0" which works surprisingly well.

mmalerba pushed a commit that referenced this issue Oct 14, 2019
Allows the consumer to configure the drag start delay based on whether it's a touch event or mouse event.

Fixes #17260.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
2 participants