Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enterPredicate called every cdkDropList #17266

Closed
doyeonOh opened this issue Oct 2, 2019 · 3 comments · Fixed by #17310 or hrueger/AGLight#112
Closed

enterPredicate called every cdkDropList #17266

doyeonOh opened this issue Oct 2, 2019 · 3 comments · Fixed by #17310 or hrueger/AGLight#112
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@doyeonOh
Copy link

doyeonOh commented Oct 2, 2019 •
edited
Loading

enterPridicate is called on every cdkDropList on dragMove.

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/fork/components-issue

working

Not working

Steps to reproduce:

  1. Drag and drop the box.
  2. Check log in console window

Expected Behavior

What behavior were you expecting to see?

  • I was expecting enterPredicate to only work on the drop target cdkDropList when dragging and dropping.

Actual Behavior

What behavior did you actually see?

  • Only the drop target cdkDropList does not work and enterPredicate is called on all cdkDropLists.
  • cdk 7.1.1 will work as intended, but 8.2.0 will not work as intended.

Environment

  • Angular: 8.2,0
  • CDK/Material: 8.2.0
  • Browser(s): chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): ubuntu 19.04
@crisbeto crisbeto self-assigned this Oct 6, 2019
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Oct 6, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 6, 2019
@crisbeto
fix(drag-drop): only call enterPredicate when pointer is inside drop …
81857ef 
…list

Fixes the `enterPredicate` being called for each connected container, even if the pointer is outside of it.

Fixes angular#17266.
@crisbeto crisbeto mentioned this issue Oct 6, 2019
Merged
@gonlliuk
Copy link

gonlliuk commented Oct 8, 2019

@crisbeto Hello! Could you tell me, when the issue's PR will be merged and new version of cdk will be published to npm? We want to release a new version of our app in a few days, and just don't know, should we wait for this bug fix? Thx a lot :)

@crisbeto
Copy link
Member

crisbeto commented Oct 8, 2019

This isn't super high on our priority list so it probably won't make it into release within the next few days.

jelbourn pushed a commit that referenced this issue Oct 11, 2019
@crisbeto @jelbourn
fix(drag-drop): only call enterPredicate when pointer is inside drop …
9fe32c0 
…list (#17310)

Fixes the `enterPredicate` being called for each connected container, even if the pointer is outside of it.

Fixes #17266.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
3 participants
@doyeonOh @crisbeto @gonlliuk