Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CdkDropList autoScrollDisabled should use coerceBooleanProperty #17475

Closed
skrtheboss opened this issue Oct 23, 2019 · 2 comments · Fixed by #17480 or hrueger/AGLight#112
Closed

CdkDropList autoScrollDisabled should use coerceBooleanProperty #17475

skrtheboss opened this issue Oct 23, 2019 · 2 comments · Fixed by #17480 or hrueger/AGLight#112
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@skrtheboss
Copy link
Contributor

Reproduction

Steps to reproduce:

  1. add cdkDropListAutoScrollDisabled attribute to cdkDropList
  2. autoScroll is not disabled

Expected Behavior

AutoScroll should be disabled by adding cdkDropListAutoScrollDisabled without setting it to true explicitely.

Actual Behavior

With the acual behaviour you need to write [cdkDropListAutoScrollDisabled]="true"

Environment

  • Angular: 8.2.11
  • CDK/Material: 8.2.3
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Widnows
@skrtheboss
Copy link
Contributor Author

coearceBooleanProperty should be added here:

https://github.com/angular/components/blob/master/src/cdk/drag-drop/directives/drop-list.ts#L124

@crisbeto crisbeto self-assigned this Oct 23, 2019
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 23, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 23, 2019
@crisbeto
fix(drag-drop): coerce drop list autoScrollDisabled input
075eb02 
Coerces the `autoScrollDisabled` input to a boolean. Also removes the getter/setter from `sortingDisabled` since we can coerce it before passing it to the drag ref instead.

Fixes angular#17475.
@crisbeto crisbeto mentioned this issue Oct 23, 2019
Merged
mmalerba pushed a commit that referenced this issue Oct 25, 2019
@crisbeto @mmalerba
fix(drag-drop): coerce drop list autoScrollDisabled input
9201a9d 
Coerces the `autoScrollDisabled` input to a boolean. Also removes the getter/setter from `sortingDisabled` since we can coerce it before passing it to the drag ref instead.

Fixes #17475.
mmalerba pushed a commit that referenced this issue Oct 28, 2019
@crisbeto @mmalerba
fix(drag-drop): coerce drop list autoScrollDisabled input (#17480)
e2de5e6 
Coerces the `autoScrollDisabled` input to a boolean. Also removes the getter/setter from `sortingDisabled` since we can coerce it before passing it to the drag ref instead.

Fixes #17475.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @skrtheboss