Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng update v9 "MatProgressSpinnerModule" was not found in the Material library. #17715

Closed
elvirdolic opened this issue Nov 15, 2019 · 2 comments · Fixed by #17717 or hrueger/AGLight#112
Closed
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Milestone

Comments

@elvirdolic
Copy link

Reproduction

When I run ng update @angular/material@next I got following warnings where the import path can't be changed and needs to be done manually. It seems somehow related to MatProgressSpinnerModule because all warning are related to this Module

Here is one file which was not migrated:

import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { LoadingSpinnerComponent } from './loading-spinner.component';
import { MatProgressSpinnerModule } from '@angular/material';
import { LoadingSpinner } from './loading-spinner';

@NgModule({
  imports: [CommonModule, MatProgressSpinnerModule],
  declarations: [LoadingSpinnerComponent],
  exports: [LoadingSpinnerComponent],
  entryComponents: [LoadingSpinnerComponent],
  providers: [LoadingSpinner]
})
export class LoadingSpinnerModule {}

Expected Behavior

What behavior were you expecting to see?

That all files are migrated

Actual Behavior

What behavior did you actually see?

That some files are not migrated

Environment

Angular CLI: 9.0.0-rc.2
Node: 12.3.1
OS: win32 x64
Angular: 9.0.0-rc.2
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.3
@angular-devkit/build-angular     0.900.0-rc.2
@angular-devkit/build-optimizer   0.900.0-rc.2
@angular-devkit/build-webpack     0.900.0-rc.2
@angular-devkit/core              9.0.0-rc.2
@angular-devkit/schematics        8.3.3
@angular/flex-layout              8.0.0-beta.26
@angular/pwa                      0.801.3
@ngtools/webpack                  9.0.0-rc.2
@schematics/angular               8.1.3
@schematics/update                0.900.0-rc.2
rxjs                              6.5.3
typescript                        3.6.4
webpack                           4.41.2
@devversion devversion self-assigned this Nov 15, 2019
@devversion
Copy link
Member

Thanks for reporting this. This seems to be a bug in our V9 update migration. Please change the import that brings in the MatProgressSpinnerModule symbol to @angular/material/progress-spinner.

@devversion devversion added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Nov 15, 2019
devversion added a commit to devversion/material2 that referenced this issue Nov 15, 2019
For v9 we generated a mapping of symbols and their corresponding secondary
entry-points. This map was based on the public API goldens we generate with
ts-api-guardian. Unfortunately ts-api-guardian has known limitations with
aliased exports which do not have the export keyword on the actual declaration.

This means that we currently do not have a mapping for such exports. Temporarily
changing ts-api-guardian to handle such cases showed that the progress-bar module is the only instance in the project.

Fixes angular#17715.
@devversion devversion added this to the 9.0.0 milestone Nov 15, 2019
andrewseguin pushed a commit that referenced this issue Nov 15, 2019
…17717)

For v9 we generated a mapping of symbols and their corresponding secondary
entry-points. This map was based on the public API goldens we generate with
ts-api-guardian. Unfortunately ts-api-guardian has known limitations with
aliased exports which do not have the export keyword on the actual declaration.

This means that we currently do not have a mapping for such exports. Temporarily
changing ts-api-guardian to handle such cases showed that the progress-bar module is the only instance in the project.

Fixes #17715.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
2 participants