Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuItem Directive #18013

Closed
rcketscientist opened this issue Dec 20, 2019 · 3 comments · Fixed by #18055
Closed

MenuItem Directive #18013

rcketscientist opened this issue Dec 20, 2019 · 3 comments · Fixed by #18055
Assignees
@crisbeto
Labels
docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project

Comments

@rcketscientist
Copy link

https://github.com/angular/components/blob/master/src/material/menu/menu-item.ts#L42

It is referred to as a directive, but is a Component and indeed doesn't have a template. Is there a reason it's Component?
@rcketscientist rcketscientist added the docs This issue is related to documentation label Dec 20, 2019
@crisbeto
Copy link
Member

Technically all components are also directives, but we should be more accurate in the docs. I'm not sure about the point that it doesn't have a template, because one can be found here.

@rcketscientist
Copy link
Author

Meh, reading comprehension...it's gonna be big. Totally missed the last line templateUrl, sorry.

@crisbeto crisbeto added the good first issue This issue is a good place to start for first time contributors to the project label Dec 20, 2019
@crisbeto crisbeto self-assigned this Dec 27, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 27, 2019
@crisbeto
docs(menu): fix inaccurate descriptions
3e4bead 
Fixes the inaccurate description of the menu item which was saying that it's a directive (even though it's a component) and that it's only there to provide the `role`. Also updates the description for the menu trigger.

Fixes angular#18013.
@crisbeto crisbeto mentioned this issue Dec 27, 2019
Merged
mmalerba pushed a commit that referenced this issue Jan 10, 2020
@crisbeto @mmalerba
docs(menu): fix inaccurate descriptions (#18055)
fad8d24 
Fixes the inaccurate description of the menu item which was saying that it's a directive (even though it's a component) and that it's only there to provide the `role`. Also updates the description for the menu trigger.

Fixes #18013.
yifange pushed a commit to yifange/components that referenced this issue Jan 30, 2020
@crisbeto @yifange
docs(menu): fix inaccurate descriptions (angular#18055)
bbfd1a2 
Fixes the inaccurate description of the menu item which was saying that it's a directive (even though it's a component) and that it's only there to provide the `role`. Also updates the description for the menu trigger.

Fixes angular#18013.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(menu): fix inaccurate descriptions crisbeto/material2
2 participants
@rcketscientist @crisbeto