fix(schematics): global typography class always being added #18315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In angular#17602 a new prompt to `ng-add` was added which allowed consumers to opt into adding the `mat-typgoraphy` style globally, but it looks like the option was never read so the class is always being added. Fixes angular#16776.
crisbeto
added
P2
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
reviewed
Jan 28, 2020
|
I was trying out the release candidate for a different reason, but this one caught my eye right away 😅 |
|
Thanks for reporting! @LayZeeDK |
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…18315) In angular#17602 a new prompt to `ng-add` was added which allowed consumers to opt into adding the `mat-typgoraphy` style globally, but it looks like the option was never read so the class is always being added. Fixes angular#16776.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17602 a new prompt to
ng-addwas added which allowed consumers to opt into adding themat-typgoraphystyle globally, but it looks like the option was never read so the class is always being added.Fixes #16776.