Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(MatSelectionList): material auto unchecked option when options rebuild #19828

Open
keatkeat87 opened this issue Jul 1, 2020 · 0 comments
Open

bug(MatSelectionList): material auto unchecked option when options rebuild #19828

keatkeat87 opened this issue Jul 1, 2020 · 0 comments
Labels
area: material/list needs investigation A member of the team needs to do further investigation to determine the root cause P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@keatkeat87
Copy link

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/fork/components-issue
https://stackblitz.com/edit/angular-puxzxe?file=src%2Fapp%2Flist-selection-example.html

Steps to reproduce:

  1. click add and select new

Expected Behavior

all options checked

Actual Behavior

only last option checked, others be unchecked (don't understand why)

Detail:
I'm trying to do a select options, and it able to "add and select new option".
the final look is something like below.
issue1
above stackblitz is minimized reproduction.

I found that, it only happens when "trackBy" + [value], if i remove trackBy then working good.
or if i don't use [value] also working good

Environment

Angular CLI: 10.0.0
Node: 12.18.0
OS: win32 x64

Angular: 10.0.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.1000.0
@angular-devkit/build-angular 0.1000.0
@angular-devkit/build-ng-packagr 0.1000.0
@angular-devkit/build-optimizer 0.1000.0
@angular-devkit/build-webpack 0.1000.0
@angular-devkit/core 10.0.0
@angular-devkit/schematics 10.0.0
@angular/cdk 10.0.1
@angular/cli 10.0.0
@angular/material 10.0.1
@angular/material-moment-adapter 10.0.1
@ngtools/webpack 10.0.0
@schematics/angular 10.0.0
@schematics/update 0.1000.0
ng-packagr 10.0.0
rxjs 6.5.5
typescript 3.9.5
webpack 4.43.0
@keatkeat87 keatkeat87 added the needs triage This issue needs to be triaged by the team label Jul 1, 2020
@crisbeto crisbeto added area: material/list needs investigation A member of the team needs to do further investigation to determine the root cause P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Jul 3, 2020
swseverance pushed a commit to swseverance/material2 that referenced this issue Jul 6, 2020
fix(material/list): use compareWith to determine if option value ch…
7cd4b77 
…anged (angular#19828)

When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.
swseverance pushed a commit to swseverance/material2 that referenced this issue Jul 6, 2020
fix(list): determine if option value changed (angular#19828)
71fcff6 
When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.
swseverance pushed a commit to swseverance/material2 that referenced this issue Jul 7, 2020
fix(list): determine if option value changed (angular#19828)
e269b2a 
When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.
mmalerba pushed a commit that referenced this issue Jul 10, 2020
@mmalerba
fix(list): determine if option value changed (#19828)
7cfe587 
When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.
wagnermaciel pushed a commit that referenced this issue Aug 20, 2020
fix(list): determine if option value changed (#19828) (#19870)
f9c5ffe 
When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.
wagnermaciel pushed a commit that referenced this issue Aug 20, 2020
@wagnermaciel
fix(list): determine if option value changed (#19828) (#19870)
c654589 
When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.

(cherry picked from commit f9c5ffe)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@wagnermaciel
fix(list): determine if option value changed (angular#19828) (angular…
a2cc549 
…#19870)

When the value of a `mat-list-option` is updated, the `mat-selection-list` `compareWith` function should be used to compare the new value with the old value. This prevents options from being incorrectly unselected when the option value is updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: material/list needs investigation A member of the team needs to do further investigation to determine the root cause P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crisbeto @keatkeat87