Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-input floating placeholder misaligned in RTL #2034

Closed
AsherBarak opened this issue Nov 30, 2016 · 5 comments · Fixed by #2047
Closed

md-input floating placeholder misaligned in RTL #2034

AsherBarak opened this issue Nov 30, 2016 · 5 comments · Fixed by #2047
Assignees
@crisbeto @mmalerba

Comments

@AsherBarak
Copy link

AsherBarak commented Nov 30, 2016 •
edited
Loading

Bug, feature request, or proposal:

feature request

What is the use-case or motivation for changing an existing behavior?

Support for right to left languages, display direction and flow

Which versions of Angular, Material, OS, browsers are affected?

All

Is there anything else we should know?
@crisbeto
Copy link
Member

Most of the components should already have support for RTL. Have you run into any issues?

@AsherBarak
Copy link
Author

Check out his screenshot
image

@crisbeto crisbeto self-assigned this Dec 1, 2016
@crisbeto crisbeto added the has pr label Dec 1, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 1, 2016
@crisbeto
fix(input): label alignment in rtl
1199fbf 
Fixes the focused label alignment being off in RTL.

Fixes angular#2034.
@crisbeto crisbeto mentioned this issue Dec 1, 2016
Merged
@jelbourn jelbourn changed the title Right to left support (for Hebrew and Arabic) Floating placeholder misaligned in RTL Dec 8, 2016
@jelbourn jelbourn changed the title Floating placeholder misaligned in RTL md-input floating placeholder misaligned in RTL Dec 8, 2016
@jelbourn
Copy link
Member

jelbourn commented Dec 8, 2016

@mmalerba we should apply fix to new md-input as well

@mmalerba
Copy link
Contributor

mmalerba commented Dec 9, 2016

looks like it should just work since i'm relying on the same css

mmalerba pushed a commit that referenced this issue Dec 9, 2016
@crisbeto @mmalerba
fix(input): label alignment in rtl (#2047)
7b3a059 
Fixes the focused label alignment being off in RTL.

Fixes #2034.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

@mmalerba mmalerba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input): label alignment in rtl crisbeto/material2
4 participants
@jelbourn @crisbeto @AsherBarak @mmalerba