-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/a11y): add ConfigurableFocusTrapConfig to the public API #22138
Merged
andrewseguin
merged 1 commit into
angular:master
from
DevIntent:docs-api-configurable-focus-trap-config
Mar 19, 2021
Merged
fix(cdk/a11y): add ConfigurableFocusTrapConfig to the public API #22138
andrewseguin
merged 1 commit into
angular:master
from
DevIntent:docs-api-configurable-focus-trap-config
Mar 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f21e8ef
to
60bcb1d
Compare
crisbeto
reviewed
Mar 7, 2021
60bcb1d
to
186df51
Compare
jelbourn
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- `ConfigurableFocusTrap` is already in the public API and it depends on this class - convert `ConfigurableFocusTrapConfig` from a class to an interface - fix alphabetization of exports Relates to angular#18201. Relates to angular#22136.
186df51
to
3fb4d91
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: cdk/a11y
cla: yes
PR author has agreed to Google's Contributor License Agreement
docs
This issue is related to documentation
P2
The issue is important to a large percentage of users, with a workaround
target: minor
This PR is targeted for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigurableFocusTrap
is already in the public API and it depends on this classConfigurableFocusTrapConfig
from a class to an interfaceRelates to #18201. Relates to #22136.
This class and it's API documentation does not currently show up in the API docs. I am expecting that adding it to the public API will get the doc generation to include it. Please let me know if this is incorrect.