feat(cdk/focus-trap) Backwards compatible factory create method #18336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
vanessanschmitt
force-pushed
the
focus-trap-constructor
branch
from
b28bade to
872ad38
Compare
jelbourn
reviewed
Jan 30, 2020
vanessanschmitt
force-pushed
the
focus-trap-constructor
branch
from
872ad38 to
04ee569
Compare
crisbeto
reviewed
Feb 1, 2020
| @@ -6,6 +6,6 @@ | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
|
|
|||
| export class ConfigurableFocusTrapConfig<D = any> { | |||
| export class ConfigurableFocusTrapConfig { | |||
| defer: boolean = false; | |||
There was a problem hiding this comment.
We should have docs on the class and the defer property since it's not immediately obvious what deferring means in this case.
There was a problem hiding this comment.
Was this just a request for adding comments or API docs? It looks like this Class isn't in the API docs since it wasn't added to the public API in
components/src/cdk/a11y/public-api.ts
Lines 12 to 16 in c7edf03
Optionally accept a boolean instead of a ConfigurableFocusTrapConfig
object in the ConfigurableFocusTrapFactory create method, so that
it is backwards compatible with FocusTrapFactory create.
This will enable apps to turn on the new functionality with
{provide: FocusTrapFactory, useClass: ConfigurableFocusTrapFactory}.
vanessanschmitt
force-pushed
the
focus-trap-constructor
branch
from
04ee569 to
2884bbc
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally accept a boolean instead of a ConfigurableFocusTrapConfig
object in the ConfigurableFocusTrapFactory create method, so that
it is backwards compatible with FocusTrapFactory create.
This will enable apps to turn on the new functionality with
{provide: FocusTrapFactory, useClass: ConfigurableFocusTrapFactory}.