Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(material-experimental/mdc-button): should have 48px touch target at default density level #22799

Closed
mmalerba opened this issue May 25, 2021 · 1 comment · Fixed by #22846 or #22931
Closed

bug(material-experimental/mdc-button): should have 48px touch target at default density level #22799

mmalerba opened this issue May 25, 2021 · 1 comment · Fixed by #22846 or #22931
Assignees
@crisbeto
Labels
area: material/button P2 The issue is important to a large percentage of users, with a workaround

Comments

@mmalerba
Copy link
Contributor

Not all button variants currently meet this requirement. We should be able to add the mdc-button--touch class to achieve this: https://github.com/material-components/material-components-web/tree/master/packages/mdc-button#making-buttons-accessible

We should do this sooner rather than later, as it will only become more difficult to land over time.
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround area: material/button labels May 25, 2021
@crisbeto crisbeto self-assigned this May 31, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue May 31, 2021
@crisbeto
fix(material-experimental/mdc-button): set proper touch target
4cb4e30 
Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes angular#22799.
@crisbeto crisbeto mentioned this issue May 31, 2021
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 2, 2021
@crisbeto
fix(material-experimental/mdc-button): set proper touch target
af46e74 
Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes angular#22799.
andrewseguin pushed a commit that referenced this issue Jun 7, 2021
@crisbeto
fix(material-experimental/mdc-button): set proper touch target (#22846)
793e1f1 
Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes #22799.
andrewseguin pushed a commit that referenced this issue Jun 7, 2021
@crisbeto @andrewseguin
fix(material-experimental/mdc-button): set proper touch target (#22846)
f2c994b 
Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes #22799.

(cherry picked from commit 793e1f1)
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 9, 2021
@crisbeto
fix(material-experimental/mdc-button): set proper touch target
6b94299 
This is a reimplementation of angular#22846 which includes a fix for RTL layouts.

Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes angular#22799.
@crisbeto crisbeto mentioned this issue Jun 9, 2021
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 9, 2021
@crisbeto
fix(material-experimental/mdc-button): set proper touch target
6ba6c78 
This is a reimplementation of angular#22846 which includes a fix for RTL layouts.

Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes angular#22799.
wagnermaciel pushed a commit that referenced this issue Jun 14, 2021
@crisbeto
fix(material-experimental/mdc-button): set proper touch target (#22931)
3284496 
This is a reimplementation of #22846 which includes a fix for RTL layouts.

Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes #22799.
wagnermaciel pushed a commit that referenced this issue Jun 14, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-button): set proper touch target (#22931)
0012409 
This is a reimplementation of #22846 which includes a fix for RTL layouts.

Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.

Fixes #22799.

(cherry picked from commit 3284496)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/button P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @mmalerba