Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/testing): extract hidden text in web driver element #23239

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix(cdk/testing): extract hidden text in web driver element #23239

merged 1 commit into from
Jul 26, 2021

Conversation

crisbeto
Copy link
Member

In #21540 we added support for extracting text from hidden elements in Protractor, but before the PR could be merged, we introduced the WebDriver environment which didn't include the fix and is failing the e2e tests.

These changes port over the fix.

@crisbeto
fix(cdk/testing): extract hidden text in web driver element
bb533ca 
In angular#21540 we added support for extracting text from hidden elements in Protractor, but before the PR could be merged, we introduced the WebDriver environment which didn't include the fix and is failing the e2e tests.

These changes port over the fix.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jul 24, 2021
@crisbeto crisbeto requested review from devversion and mmalerba July 24, 2021 05:59
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 24, 2021
devversion
devversion approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jul 24, 2021
@mmalerba mmalerba merged commit 0742bab into angular:master Jul 26, 2021
mmalerba pushed a commit that referenced this pull request Jul 26, 2021
@crisbeto @mmalerba
fix(cdk/testing): extract hidden text in web driver element (#23239)
51b7cba 
In #21540 we added support for extracting text from hidden elements in Protractor, but before the PR could be merged, we introduced the WebDriver environment which didn't include the fix and is failing the e2e tests.

These changes port over the fix.

(cherry picked from commit 0742bab)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @mmalerba