fix(cdk/testing): protractor element not extracting hidden text

[crisbeto]

We use Protractor's getText method to extract text, but the problem is that it's likely based on HTMLElement.innerText which excludes text from hidden elements.

These changes switch to using textContent to bring the behavior in-line with the UnitTestElement.

[jelbourn]

LGTM

[jelbourn]

Caretaker note: this has a chance of breaking some e2e tests, but I suspect it to be somewhat unlikely

[mmalerba]

There were only a few failures as a result of this, but investigating one of them uncovered something that I guess is more of a problem with the stepper. The stepper leaves steps that are not visible in the DOM. There is a project using MatButtonHarness to get the "Next" button, but with this change it always gets the button for the first step, regardless of what step is shown. Any thoughts on what the right solution to this is?

[crisbeto]

I suppose to correct way to handle it would be to use a selector. They would've had this issue if they were running the test using TestBed as well.

[mmalerba]

Isn't a selector just going to have the same problem? I didn't really see any classes that identify the currently visible step to select on

[crisbeto]

Doesn't look like we have any classes that would identify it so the stepper harness uses aria-selected for it. Maybe something like MatButtonHarness.with({text: 'Next', ancestor: '[aria-selected="true"]'})?

[mmalerba]

Ok that seems reasonable, or better yet maybe I can just change their test to use the stepper harness

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}