Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(many): systemic issue where svg images do not have appropriate role #27113

Closed
1 task
zarend opened this issue May 17, 2023 · 1 comment · Fixed by #27116
Closed
1 task

bug(many): systemic issue where svg images do not have appropriate role #27113

zarend opened this issue May 17, 2023 · 1 comment · Fixed by #27116
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: many Area label for issues related to many components P4 A relatively minor issue that is not relevant to core functions

Comments

@zarend
Copy link
Contributor

zarend commented May 17, 2023

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Many of our SVG images do not have an appropriate role, such as role="image". SVGs should have an appropriate role or have aria-hidden="true" instead.

This has caused some P4 issues for us. Would be easier to add aria-hidden="true" to Decorative images since that is not hard to do.

Reproduction

Steps to reproduce:
1.
2.

Expected Behavior

Decorative SVG's have aria-hidden="true"

Actual Behavior

Some of the decorative SVG's do not have aria-hidden

Environment

  • Angular:
  • CDK/Material:
  • Browser(s):
  • Operating System (e.g. Windows, macOS, Ubuntu):
@zarend zarend added Accessibility This issue is related to accessibility (a11y) P4 A relatively minor issue that is not relevant to core functions area: many Area label for issues related to many components labels May 17, 2023
@crisbeto crisbeto self-assigned this May 18, 2023
crisbeto added a commit to crisbeto/material2 that referenced this issue May 18, 2023
@crisbeto
fix(multiple): set aria-hidden on presentational svgs
6025352 
Adds `aria-hidden` on all SVG nodes that didn't have them already to prevent them from being treated as images.

Fixes angular#27113.
@crisbeto crisbeto mentioned this issue May 18, 2023
Merged
angular-robot bot pushed a commit that referenced this issue May 19, 2023
@crisbeto
fix(multiple): set aria-hidden on presentational svgs (#27116)
b637301 
Adds `aria-hidden` on all SVG nodes that didn't have them already to prevent them from being treated as images.

Fixes #27113.
angular-robot bot pushed a commit that referenced this issue May 19, 2023
@crisbeto
fix(multiple): set aria-hidden on presentational svgs (#27116)
12474aa 
Adds `aria-hidden` on all SVG nodes that didn't have them already to prevent them from being treated as images.

Fixes #27113.

(cherry picked from commit b637301)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: many Area label for issues related to many components P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(multiple): set aria-hidden on presentational svgs crisbeto/material2
2 participants
@crisbeto @zarend