-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(mat-button): Ripple effect missing when using encapsulation: ShadowDom #29011
Labels
Comments
amysorto
added
P4
A relatively minor issue that is not relevant to core functions
area: material/button
and removed
needs triage
This issue needs to be triaged by the team
labels
May 7, 2024
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
May 8, 2024
Fixes the following issues that prevented the button ripples from being loaded in the shadow DOM: * We weren't resolving the event target properly. * We were using `click` as a fallback which happens too late for the very first ripple. These changes switch to `mousedown`. Fixes angular#29011.
A couple of notes:
|
crisbeto
added a commit
that referenced
this issue
May 9, 2024
Fixes the following issues that prevented the button ripples from being loaded in the shadow DOM: * We weren't resolving the event target properly. * We were using `click` as a fallback which happens too late for the very first ripple. These changes switch to `mousedown`. Fixes #29011.
crisbeto
added a commit
that referenced
this issue
May 9, 2024
Fixes the following issues that prevented the button ripples from being loaded in the shadow DOM: * We weren't resolving the event target properly. * We were using `click` as a fallback which happens too late for the very first ripple. These changes switch to `mousedown`. Fixes #29011. (cherry picked from commit 7553e1c)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Is this a regression?
The previous version in which this bug was not present was
No response
Description
When using
encapsulation: ViewEncapsulation.ShadowDom
in a component, the ripple effect on any material buttons is missing.Reproduction
StackBlitz link: https://stackblitz.com/edit/stackblitz-starters-ggkhap?file=src%2Fshadow-buttons.component.ts
Steps to reproduce:
Expected Behavior
All four buttons show a ripple effect.
Actual Behavior
Only the buttons using the default encapsulation has a ripple, and the ones in the shadow dom does not.
shadow-ripple.webm
Environment
The text was updated successfully, but these errors were encountered: