-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MdDialog] opening multiple dialog return wrong dialogRef. #6560
Labels
P4
A relatively minor issue that is not relevant to core functions
Comments
@crisbeto we should do something to make this behavior more obvious |
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Oct 28, 2017
The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in angular#5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating. Fixes angular#6560.
andrewseguin
pushed a commit
that referenced
this issue
Nov 2, 2017
…8051) The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in #5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating. Fixes #6560.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug, feature request, or proposal:
Bug
What is the expected behavior?
If I open a dialog while another is in the process of being opened it should be opened and return the
dialogRef
of the requested onesWhat is the current behavior?
The requested dialog is ignored and a return a dialogRef which not belong the the requested dialog
What are the steps to reproduce?
https://github.com/angular/material2/blob/master/src/lib/dialog/dialog.ts#L123-L126
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: