Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slide toggle not centered when no text/label #6868

Closed
vegarda opened this issue Sep 6, 2017 · 1 comment · Fixed by #6881
Closed

Slide toggle not centered when no text/label #6868

vegarda opened this issue Sep 6, 2017 · 1 comment · Fixed by #6881
Assignees
@devversion

Comments

@vegarda
Copy link

vegarda commented Sep 6, 2017

Bug, feature request, or proposal:

Bug/improvement

What is the expected behavior?

Slide toggle to be centered when no text/label

What is the current behavior?

Slide toggle not centered when no text/label

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

.mat-slide-toggle-label{
height: inherit;
}

If no content/text/label:

.mat-slide-toggle-bar{
margin-right: 0;
}

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

beta10

Is there anything else we should know?

Maybe have *ngIf on .mat-slide-toggle-content and margin-left on it.
@devversion devversion self-assigned this Sep 6, 2017
devversion added a commit to devversion/material2 that referenced this issue Sep 6, 2017
@devversion
fix(slide-toggle): remove side-margin if slide-toggle label is empty
79449a8 
* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730)

Fixes angular#6868
@devversion devversion mentioned this issue Sep 6, 2017
Merged
devversion added a commit to devversion/material2 that referenced this issue Sep 7, 2017
@devversion
fix(slide-toggle): remove side-margin if slide-toggle label is empty
a9acfe1 
* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730)

Fixes angular#6868
devversion added a commit to devversion/material2 that referenced this issue Sep 7, 2017
@devversion
fix(slide-toggle): remove side-margin if slide-toggle label is empty
c476c0a 
* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730)

Fixes angular#6868
mmalerba pushed a commit that referenced this issue Sep 12, 2017
@devversion @mmalerba
fix(slide-toggle): remove side-margin if slide-toggle label is empty (#…
a1ec81a 
…6881)

* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in #4730)

Fixes #6868
josephperrott pushed a commit to josephperrott/components that referenced this issue Sep 15, 2017
@devversion @josephperrott
fix(slide-toggle): remove side-margin if slide-toggle label is empty (a…
bf91a89 
…ngular#6881)

* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730)

Fixes angular#6868
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slide-toggle): remove side-margin if slide-toggle label is empty devversion/material2
2 participants
@vegarda @devversion