-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expansion panels in tabs not working properly #9834
Comments
I have exactly the same problem as you do, and I also have looked at #5269 . The solutions there do apply to our case (you wrap the accordion/expansion panel with an This did not work for me. Here are some screenshots that may help: Appearance after switching tabs: I did not click anywhere in the expansion panels before switching tabs. Hope this helps in figuring out the problem, as I am also facing this issue. |
If you're looking for a workaround, you can add this :
With a tab condition
And it does this
Works well for me (once I added a fake loading bar and some animation), but still, it's a workaround, and I expect a fix to come soon |
Thanks for the fix @trichetriche . I also expect there will be a solution for this. |
The only issue I'm finding with this workaround is that the screen will scroll up to line up with the expanded content when you switch tabs. This happens when the tab container is the only element on the x axis. |
Not sure this is related to the workaround since I faced this issue when I discovered material. My solution was to make the content take the whole space anyway, and change its overflow properties |
With the submission of #8921, you should now be able to lazy load the content of the tabs. With the content of the tabs being lazy loaded, the animations move to the correct state as desired. |
But what if I don't want to lazy load the content of the tabs ? Is it the only solution to this problem ? |
At this point this is the only viable solution we have found as this is actually an issue of animations failing to trigger. We hope to be able to determine a better solution in the future, but at this point this is the best solution we have found. |
@trichetriche The solution given is not working for me. My Problem: |
That's the exact same issue I have reported and I gave a workaround around that, that worked for me (and still works as of today). If you have an issue, then provide a sandbox to show it, like you would open a question. In fact, if you think your problem is different, you should maybe open a question. |
@trichetriche Here is the code:
|
I don't really care about your code ... That doesn't show me the issue you're facing, and that doesn't show me if you tried the workaround I gave. And honestly, i didn't even read it, there's like 200 lines of your code that doesn't interest me, I've already got my answer, and that's a ticket for an issue, not for calling help. So unless you provide a sandbox to test it, I won't be willing to help you, sorry. |
I can understand, well right now I can't reveal the real code and show you
the exact issue I am facing via sandbox. You too don't have time and
unfortunately me too. I hoped you would be able recreate the issue with
that code and help me. Anyways thank you for your words.
…On 6:56PM, Fri, 20 Apr 2018 trichetriche, ***@***.***> wrote:
I don't really care about your code ... That doesn't show me the issue
you're facing, and that doesn't show me if you tried the workaround I gave.
And honestly, i didn't even read it, there's like 200 lines of your code
that doesn't interest me, I've already got my answer, and that's a ticket
for an issue, not for calling help.
So unless you provide a sandbox to test it, I won't be willing to help
you, sorry.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9834 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AjS-xuVGSZdzfW7HzEFECYUDvS_Mx3f-ks5tqeIigaJpZM4R-EiC>
.
|
I too faced this issue. A big thanks to @trichetriche for the work around! Made my life easier. |
issue is still there, |
Your link is dead and we are aware the issue is still there. As said before, it won't be corrected, but there is 2 workarounds for it. |
May be those 2 workarounds doesn't work for everyone. If it is in material
and is public to use then it should be developed in such a way that
everybody can use it without any issue.
*Thanks & Regards*
Yaseen Nadaf
Full Stack Web Developer
…On Tue, Jun 12, 2018 at 1:00 PM, trichetriche ***@***.***> wrote:
Your link is dead and we are aware the issue is still there. As said
before, it won't be corrected, but there is 2 workarounds for it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9834 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AjS-xk4JP2GeI8icUBMmlzFIEBnDk7tBks5t724YgaJpZM4R-EiC>
.
|
I would like to know the reason why it won't be corrected?
*Thanks & Regards*
Yaseen Nadaf
Full Stack Web Developer
…On Tue, Jun 12, 2018 at 1:51 PM, Yaseen Nadaf ***@***.***> wrote:
May be those 2 workarounds doesn't work for everyone. If it is in material
and is public to use then it should be developed in such a way that
everybody can use it without any issue.
*Thanks & Regards*
Yaseen Nadaf
Full Stack Web Developer
On Tue, Jun 12, 2018 at 1:00 PM, trichetriche ***@***.***>
wrote:
> Your link is dead and we are aware the issue is still there. As said
> before, it won't be corrected, but there is 2 workarounds for it.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#9834 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AjS-xk4JP2GeI8icUBMmlzFIEBnDk7tBks5t724YgaJpZM4R-EiC>
> .
>
|
The purpose of a workaround is to work. If it doesn't, that's not a workaround, it's a bug ... And in case you're not aware, devs can face limitations. If you cared to read the whole thread you would have seen that it is the case there. And again, read the thread to answer your second question. |
@trichetriche I re-pasted the link. Workarounds take additional time to implement and cost dev time, I rather not be spending time implementing a workaround, therefore it should be fixed. either ways the workaround does work. |
@trichetriche Workaround works great. Thanks! Took no time at all to implement and works as expected |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
When I switch between tabs that both have expansion panels, I want the expansion panels to behave like they would in any other situation.
What is the current behavior?
The panels are sort of opened, and their style is messed up :
What are the steps to reproduce?
Stackblitz
Is there anything else we should know?
Unlike #5269 there's no hidden tab. So I think it isn't a duplicate, hence the new issue.
The text was updated successfully, but these errors were encountered: